Bug 141904

Summary:

UNREACHABLE_FOR_PLATFORM() should be release assert

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, fpizlo, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2015-02-23 06:20:00 PST

UNREACHABLE_FOR_PLATFORM() should be release assert

Comment 1 Csaba Osztrogonác 2015-02-23 06:21:15 PST

Created attachment 247114 [details]
Patch

Comment 2 Csaba Osztrogonác 2015-02-23 06:25:36 PST

Now it is relase assert with clang, but debug assert otherwise.
Additionally RELEASE_ASSERT_NOT_REACHED(); is simple crash in
release mode, but it is more verbose in debug mode.

Releated discussion can be found here:
https://bugs.webkit.org/show_bug.cgi?id=141489#c10 ( and c11, c12 )

just a note: It depends on bug141903. We should wait until 
bug141903 is fixed not to break the ARM traditional world.

Comment 3 WebKit Commit Bot 2015-02-26 02:51:16 PST

Comment on attachment 247114 [details]
Patch

Clearing flags on attachment: 247114

Committed r180668: <http://trac.webkit.org/changeset/180668>

Comment 4 WebKit Commit Bot 2015-02-26 02:51:19 PST

All reviewed patches have been landed.  Closing bug.