Bug 141685

Summary: Update expected result of fast/forms/text-control-intrinsic-widths.html after r177774
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, commit-queue, dino, jonlee, rniwa, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 139968    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews105 for mac-mavericks-wk2
none
Archive of layout-test-results from ews103 for mac-mavericks
none
Patch ap: review+, commit-queue: commit-queue-

Myles C. Maxfield
Reported 2015-02-16 17:51:12 PST
Update expected result of fast/forms/text-control-intrinsic-widths.html after r177774
Attachments
Patch (7.00 KB, patch)
2015-02-16 17:51 PST, Myles C. Maxfield
no flags
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (673.29 KB, application/zip)
2015-02-16 18:28 PST, Build Bot
no flags
Archive of layout-test-results from ews103 for mac-mavericks (527.33 KB, application/zip)
2015-02-16 18:39 PST, Build Bot
no flags
Patch (15.49 KB, patch)
2015-02-17 21:21 PST, Myles C. Maxfield
ap: review+
commit-queue: commit-queue-
Myles C. Maxfield
Comment 1 2015-02-16 17:51:42 PST
Build Bot
Comment 2 2015-02-16 18:27:56 PST
Comment on attachment 246709 [details] Patch Attachment 246709 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6077909110358016 New failing tests: fast/forms/text-control-intrinsic-widths.html
Build Bot
Comment 3 2015-02-16 18:28:00 PST
Created attachment 246712 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Build Bot
Comment 4 2015-02-16 18:39:13 PST
Comment on attachment 246709 [details] Patch Attachment 246709 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6684858856243200 New failing tests: fast/forms/text-control-intrinsic-widths.html
Build Bot
Comment 5 2015-02-16 18:39:16 PST
Created attachment 246715 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Myles C. Maxfield
Comment 6 2015-02-17 21:21:22 PST
WebKit Commit Bot
Comment 7 2015-02-18 15:51:08 PST
Comment on attachment 246798 [details] Patch Rejecting attachment 246798 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 246798, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /mac-mavericks/fast/forms/text-control-intrinsic-widths-expected.txt patching file LayoutTests/platform/mac/TestExpectations Hunk #1 FAILED at 1265. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej patching file LayoutTests/platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6697096291811328
Myles C. Maxfield
Comment 8 2015-02-18 15:59:27 PST
Alexey Proskuryakov
Comment 9 2015-02-18 20:20:12 PST
This test is now failing on Yosemite: Verdana input -size=1 clientWidth=24 -size=2 clientWidth=30 -size=3 clientWidth=36 -size=4 clientWidth=42 -size=5 clientWidth=48 -size=10 clientWidth=78 -size=20 clientWidth=138 -size=50 clientWidth=318 -size=100 clientWidth=618 -size=500 clientWidth=3018 -size=1000 clientWidth=6018 +size=1 clientWidth=23 +size=2 clientWidth=29 +size=3 clientWidth=35 +size=4 clientWidth=41 +size=5 clientWidth=47 +size=10 clientWidth=77 +size=20 clientWidth=137 +size=50 clientWidth=317 +size=100 clientWidth=617 +size=500 clientWidth=3017 +size=1000 clientWidth=6017
Alexey Proskuryakov
Comment 10 2015-02-18 20:25:15 PST
I updated Yosemite results again in r180335. Where did the results you landed come from? I simply took the result from a bot, but I'm now concerned that it may not match what happens locally.
Myles C. Maxfield
Comment 11 2015-02-19 06:43:32 PST
(In reply to comment #10) > I updated Yosemite results again in r180335. > > Where did the results you landed come from? I simply took the result from a > bot, but I'm now concerned that it may not match what happens locally. Thanks, Alexey. You are right - that expected result is what I ran locally. There is some difference between the bots and my local machine.
Myles C. Maxfield
Comment 12 2015-02-19 14:59:14 PST
I can't reproduce the bot's results on my local machine, even when running the tests in the same order as it.
Myles C. Maxfield
Comment 13 2015-02-20 08:30:47 PST
Running shipping Yosemite, my machine agrees with the bots.
Myles C. Maxfield
Comment 14 2015-02-20 14:59:54 PST
This is because my machine has MS Office fonts installed, and CT uses these fonts preferentially over the system fonts. Verdana is one of these fonts.
Note You need to log in before you can comment on or make changes to this bug.