| Summary: | run-jsc-stress-tests --remote should skip profiler tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin, fpizlo, ggaren, mark.lam, mhahnenb, msaboff, oliver, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 141165 | ||||||
| Attachments: |
|
||||||
Created attachment 246383 [details]
Patch
It's safe to land it, because these tests are are already skipped on non-X86 Darwin and Windows platforms. (Enabled on X86-Darwin and all Linux platforms) https://bugs.webkit.org/show_bug.cgi?id=133149#c7 says the original goal was to skip these tests for remote testing. So here is the proper skipping. Filip, could you possibly review it? Comment on attachment 246383 [details] Patch Clearing flags on attachment: 246383 Committed r180061: <http://trac.webkit.org/changeset/180061> All reviewed patches have been landed. Closing bug. |
addRunCommand("profiler", ["ruby", (pathToHelpers + "profiler-test-helper").to_s, (SCRIPTS_PATH + "display-profiler-output").to_s, profilerOutput.to_s, pathToVM.to_s, "-p", profilerOutput.to_s, $benchmark.to_s], silentOutputHandler, simpleErrorHandler) profiler tests now depends on many local paths: - SCRIPTS_PATH - profilerOutput - generated by uniqueFilename which does everything locally I think we should simply disable profiler tests for remote testing until proper fix.