Summary: | a few more WEBCORE_EXPORT macros | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
Component: | WebCore Misc. | Assignee: | Alex Christensen <achristensen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 136172 | ||||||||
Attachments: |
|
Description
Alex Christensen
2015-02-09 15:42:17 PST
Created attachment 246300 [details]
Patch
Comment on attachment 246300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246300&action=review > Source/WebCore/bindings/js/JSDOMGlobalObject.h:71 > - static WEBKIT_EXPORTDATA const JSC::ClassInfo s_info; > + WEBCORE_EXPORT static const JSC::ClassInfo s_info; Are these changes right? > Source/WebCore/bindings/objc/DOMInternal.h:53 > +WEBCORE_EXPORT @interface DOMNodeFilter : DOMObject <DOMNodeFilter> ‽ ‽ how > Source/WebCore/page/DatabaseProvider.h:36 > +class WEBCORE_EXPORT DatabaseProvider : public RefCounted<DatabaseProvider> { What does it mean to export a class? Also, is this the right placement for this? (In reply to comment #2) > Comment on attachment 246300 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=246300&action=review > > > Source/WebCore/bindings/js/JSDOMGlobalObject.h:71 > > - static WEBKIT_EXPORTDATA const JSC::ClassInfo s_info; > > + WEBCORE_EXPORT static const JSC::ClassInfo s_info; > > Are these changes right? Yes. When I make the switch, I'm going to get rid of WEBKIT_EXPORTDATA in favor of WEBCORE_EXPORT, which does the same thing. > > > Source/WebCore/bindings/objc/DOMInternal.h:53 > > +WEBCORE_EXPORT @interface DOMNodeFilter : DOMObject <DOMNodeFilter> > > ‽ ‽ how I'm not sure, but this fixes linker errors of missing symbols like _OBJC_CLASS_$_DOMNodeFilter and _OBJC_METACLASS_$_DOMNodeFilter. > > > Source/WebCore/page/DatabaseProvider.h:36 > > +class WEBCORE_EXPORT DatabaseProvider : public RefCounted<DatabaseProvider> { > > What does it mean to export a class? Also, is this the right placement for > this? This is the right placement. It exports the vtable. Created attachment 246303 [details]
Patch
I added changes to the bindings tests. Comment on attachment 246303 [details] Patch Clearing flags on attachment: 246303 Committed r179861: <http://trac.webkit.org/changeset/179861> All reviewed patches have been landed. Closing bug. |