Bug 141179

Summary: [GTK] TestWebKitAccessibility is not skipped
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, commit-queue, mcatanzaro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Michael Catanzaro
Reported 2015-02-02 15:43:27 PST
TestWebKitAccessibility should be skipped due to bug #132134, but it's not being skipped due to a thinko.
Attachments
Patch (1.77 KB, patch)
2015-02-02 15:45 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2015-02-03 07:09 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-02-02 15:45:03 PST
Created attachment 245908 [details] Patch
Carlos Garcia Campos
Comment 2 2015-02-03 00:39:02 PST
This probably means the test is not so flaky, I prefer not to skip tests that are working.
Michael Catanzaro
Comment 3 2015-02-03 05:31:43 PST
It fails very often, or I would not propose to skip it, see bug #132134
Carlos Garcia Campos
Comment 4 2015-02-03 05:46:26 PST
(In reply to comment #3) > It fails very often, or I would not propose to skip it, see bug #132134 how often? where did you get that information from? I don't see the test failing in the bots: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29
Michael Catanzaro
Comment 5 2015-02-03 05:57:03 PST
(In reply to comment #4) > how often? I've seen it work sometimes, but it almost always fails when I run it unless it is the only test being run (and even then it sometimes works, so "flaky"). There's also bug #140413. > where did you get that information from? I don't see the test > failing in the bots: > > https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29 I don't know why it works on the bots. At least we should remove the broken skip, if nothing else.
Michael Catanzaro
Comment 6 2015-02-03 05:59:03 PST
Specifically, https://bugs.webkit.org/show_bug.cgi?id=132134#c12
Carlos Garcia Campos
Comment 7 2015-02-03 06:38:14 PST
Skipped tests are for the bots, if this depends on the environment and it works in the bots, I would just remove the incorrect skip, and let the test run in the bots. Skipped tests are a source of unnoticed regressions.
Michael Catanzaro
Comment 8 2015-02-03 07:09:28 PST
Created attachment 245938 [details] Patch
WebKit Commit Bot
Comment 9 2015-02-03 10:25:54 PST
Comment on attachment 245938 [details] Patch Clearing flags on attachment: 245938 Committed r179554: <http://trac.webkit.org/changeset/179554>
WebKit Commit Bot
Comment 10 2015-02-03 10:25:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.