Bug 141179

Summary: [GTK] TestWebKitAccessibility is not skipped
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, commit-queue, mcatanzaro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Description Michael Catanzaro 2015-02-02 15:43:27 PST 
TestWebKitAccessibility should be skipped due to bug #132134, but it's not being skipped due to a thinko.
Comment 1 Michael Catanzaro 2015-02-02 15:45:03 PST 
Created attachment 245908 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-02-03 00:39:02 PST 
This probably means the test is not so flaky, I prefer not to skip tests that are working.
Comment 3 Michael Catanzaro 2015-02-03 05:31:43 PST 
It fails very often, or I would not propose to skip it, see bug #132134
Comment 4 Carlos Garcia Campos 2015-02-03 05:46:26 PST 
(In reply to comment #3)
> It fails very often, or I would not propose to skip it, see bug #132134

how often? where did you get that information from? I don't see the test failing in the bots:

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29
Comment 5 Michael Catanzaro 2015-02-03 05:57:03 PST 
(In reply to comment #4)
> how often? 

I've seen it work sometimes, but it almost always fails when I run it unless it is the only test being run (and even then it sometimes works, so "flaky"). There's also bug #140413.

> where did you get that information from? I don't see the test
> failing in the bots:
> 
> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29

I don't know why it works on the bots.

At least we should remove the broken skip, if nothing else.
Comment 6 Michael Catanzaro 2015-02-03 05:59:03 PST 
Specifically, https://bugs.webkit.org/show_bug.cgi?id=132134#c12
Comment 7 Carlos Garcia Campos 2015-02-03 06:38:14 PST 
Skipped tests are for the bots, if this depends on the environment and it works in the bots, I would just remove the incorrect skip, and let the test run in the bots. Skipped tests are a source of unnoticed regressions.
Comment 8 Michael Catanzaro 2015-02-03 07:09:28 PST 
Created attachment 245938 [details]
Patch
Comment 9 WebKit Commit Bot 2015-02-03 10:25:54 PST 
Comment on attachment 245938 [details]
Patch

Clearing flags on attachment: 245938

Committed r179554: <http://trac.webkit.org/changeset/179554>
Comment 10 WebKit Commit Bot 2015-02-03 10:25:57 PST 
All reviewed patches have been landed.  Closing bug.