Bug 140940

Summary:

Improve mixed content layout tests

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

Tools / Tests

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED WONTFIX

Severity:

Enhancement

CC:

buildbot, cgarcia, mcatanzaro, rniwa, wilander, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

See Also:

https://bugs.webkit.org/show_bug.cgi?id=145717

Bug Depends on:

140621

Bug Blocks:

140625, 140793

Attachments:

Description	Flags
Improve mixed content layout tests	none
Archive of layout-test-results from ews101 for mac-mavericks	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none
Block mixed content XHR	none

Michael Catanzaro

Reported 2015-01-27 08:58:53 PST

Our mixed content layout tests currently just test if some code checks to see if mixed content is allowed; they don't check to see if code correctly blocks the content when it's disallowed.

Attachments
Improve mixed content layout tests (60.03 KB, patch) 2015-01-27 09:08 PST, Michael Catanzaro	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-mavericks (1.79 MB, application/zip) 2015-01-27 09:59 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (1.56 MB, application/zip) 2015-01-27 10:10 PST, Build Bot	no flags	Details
Block mixed content XHR (10.46 KB, patch) 2015-01-27 15:24 PST, Michael Catanzaro	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2015-01-27 09:05:19 PST

Note in particular that in this patch, I expose our mixed content preferences in WebPreferencesDefinitions.h.

Michael Catanzaro

Comment 2 2015-01-27 09:08:42 PST

Created attachment 245448 [details] Improve mixed content layout tests

Build Bot

Comment 3 2015-01-27 09:59:26 PST

Comment on attachment 245448 [details] Improve mixed content layout tests Attachment 245448 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6247054317715456 New failing tests: http/tests/security/mixedContent/ssl/insecure-video-in-iframe.html http/tests/security/mixedContent/ssl/insecure-image-in-iframe.html http/tests/security/mixedContent/ssl/insecure-iframe-in-iframe.html http/tests/security/mixedContent/ssl/redirect-http-to-https-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-iframe-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-image-in-iframe-cb.html http/tests/security/mixedContent/ssl/redirect-http-to-https-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-image-in-main-frame.html http/tests/security/mixedContent/ssl/redirect-https-to-http-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-video-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-script-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-css-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-image-in-main-frame-cb.html http/tests/security/mixedContent/ssl/redirect-https-to-http-script-in-iframe.html http/tests/security/mixedContent/ssl/redirect-http-to-https-script-in-iframe.html http/tests/security/mixedContent/ssl/insecure-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-audio-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-plugin-in-iframe.html http/tests/security/mixedContent/ssl/redirect-https-to-http-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-plugin-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-audio-in-iframe.html http/tests/security/mixedContent/ssl/insecure-css-in-main-frame.html http/tests/security/mixedContent/ssl/redirect-http-to-https-script-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-css-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-css-in-iframe.html http/tests/security/mixedContent/ssl/redirect-https-to-http-script-in-iframe-cb.html http/tests/security/mixedContent/ssl/insecure-script-in-iframe.html

Build Bot

Comment 4 2015-01-27 09:59:29 PST

Created attachment 245451 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-01-27 10:10:02 PST

Comment on attachment 245448 [details] Improve mixed content layout tests Attachment 245448 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6271203845079040 New failing tests: http/tests/security/mixedContent/ssl/redirect-https-to-http-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-video-in-iframe.html http/tests/security/mixedContent/ssl/insecure-audio-in-iframe.html http/tests/security/mixedContent/ssl/redirect-https-to-http-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-iframe-in-iframe-cb.html http/tests/security/mixedContent/ssl/redirect-https-to-http-script-in-iframe.html http/tests/security/mixedContent/ssl/redirect-http-to-https-script-in-iframe.html http/tests/security/mixedContent/ssl/insecure-iframe-in-iframe.html http/tests/security/mixedContent/ssl/insecure-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-css-in-iframe.html http/tests/security/mixedContent/ssl/insecure-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-image-in-iframe.html http/tests/security/mixedContent/ssl/insecure-audio-in-main-frame.html http/tests/security/mixedContent/ssl/redirect-http-to-https-iframe-in-main-frame.html http/tests/security/mixedContent/ssl/insecure-plugin-in-iframe.html http/tests/security/mixedContent/ssl/redirect-http-to-https-iframe-in-main-frame-cb.html http/tests/security/mixedContent/ssl/insecure-script-in-iframe.html http/tests/security/mixedContent/ssl/insecure-video-in-main-frame.html

Build Bot

Comment 6 2015-01-27 10:10:04 PST

Created attachment 245453 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Michael Catanzaro

Comment 7 2015-01-27 11:12:03 PST

So three problems here: 1) I forgot the patch depends on bug #140621, so I should not have marked this for review at all, and we can expect all tests with an insecure iframe to fail. 2) I forgot about WK1. This is probably very little chance of me being able to fix this speculatively, with neither Windows nor a Mac. I guess I need to find and modify the equivalent in WK1 of WK2's InjectedBundle::overrideBoolPreferenceForTestRunner(). Would be great if someone could provide guidance on this. 3) I see tons of these: [Tue Jan 27 09:49:15 2015] [error] [client 127.0.0.1] File does not exist: /Volumes/Data/EWS/WebKit/LayoutTests/http/tests/security/mixedContent/resources/empty-frame.html, referer: https://127.0.0.1:8443/security/mixedContent/ssl/redirect-https-to-http-script-in-iframe-expected.html The file is definitely present in my patch. My only guess is that some step in the process of getting the patch from bugzilla to the bots loses empty files?

Michael Catanzaro

Comment 8 2015-01-27 15:24:35 PST

Created attachment 245480 [details] Block mixed content XHR

Michael Catanzaro

Comment 9 2015-01-27 15:26:51 PST

Comment on attachment 245480 [details] Block mixed content XHR Whoops, the webkit-patch script uploaded this to the wrong bug.

Michael Catanzaro

Comment 10 2023-03-03 14:12:16 PST

Safe to say I'm never going to return to this after 8 years. The test situation is much better nowadays anyway.

Note You need to log in before you can comment on or make changes to this bug.