Summary: | [ARM] Typo fix after r176083 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, msaboff, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 108645, 136914 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2015-01-27 06:55:28 PST
Created attachment 245442 [details]
Patch
Comment on attachment 245442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245442&action=review > Source/JavaScriptCore/assembler/ARMv7Assembler.h:1158 > - ASSERT(!(imm.isUInt12() & 1)); > + ASSERT(!(imm.getUInt12() & 1)); I ran into this assertion during debugging a bug on ARM Linux. It seems to be a simple typo. isUInt12() returns a logical value: 0 as false / not 0 as true, But we can't expect if the non 0 value is an odd number. I think the author wanted to expect odd number. In this case we should use getUint12() instead of isUInt12(). Comment on attachment 245442 [details] Patch Clearing flags on attachment: 245442 Committed r179187: <http://trac.webkit.org/changeset/179187> All reviewed patches have been landed. Closing bug. |