| Summary: | [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | berto, commit-queue, gustavo, mcatanzaro, mrobinson, svillar, zan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 98932 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Carlos Garcia Campos
2015-01-26 02:19:44 PST
Created attachment 245335 [details] Patch We need to enable IndexedDB again first, see bug #98932 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 245335 [details]
Patch
I feel like we should drop the -database part from the name since 'db' already means that and it is not easy to confuse this with something that is not a database. Otherwise looks good.
(In reply to comment #3) > Comment on attachment 245335 [details] > Patch > > I feel like we should drop the -database part from the name since 'db' > already means that and it is not easy to confuse this with something that is > not a database. Otherwise looks good. Yes, I thought about that, and added the -directory because db is part of the IndexedDB, but what other thing could be the directory for? I'll update the patch, thanks for the review! Created attachment 253677 [details]
Updated patch
Comment on attachment 253677 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=253677&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:345 > + * WebKitWebContext:indexed-db-database-directory: Still has the -database bit. (In reply to comment #6) > Comment on attachment 253677 [details] > Updated patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253677&action=review > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:345 > > + * WebKitWebContext:indexed-db-database-directory: > > Still has the -database bit. Oops, good catch! Committed r184851: <http://trac.webkit.org/changeset/184851> |