| Summary: | Setting HTMLMarqueeElement.trueSpeed doesn't work | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | DOM | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kling | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=15263 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 140851 | ||||||
| Attachments: |
|
||||||
Created attachment 245308 [details]
proposed fix
Comment on attachment 245308 [details] proposed fix Clearing flags on attachment: 245308 Committed r179102: <http://trac.webkit.org/changeset/179102> All reviewed patches have been landed. Closing bug. |
HTMLMarqueeElement.trueSpeed is a boolean property, so setting it it to true sets an empty value. void Element::setBooleanAttribute(const QualifiedName& name, bool value) { if (value) setAttribute(name, emptyAtom); else removeAttribute(name); } But then HTMLMarqueeElement::minimumDelay() treats an empty value as false.