Bug 140863

Summary: Setting HTMLMarqueeElement.trueSpeed doesn't work
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: DOMAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=15263
Bug Depends on:    
Bug Blocks: 140851    
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2015-01-25 00:50:36 PST
HTMLMarqueeElement.trueSpeed is a boolean property, so setting it it to true sets an empty value. void Element::setBooleanAttribute(const QualifiedName& name, bool value) { if (value) setAttribute(name, emptyAtom); else removeAttribute(name); } But then HTMLMarqueeElement::minimumDelay() treats an empty value as false.
Attachments
proposed fix (3.74 KB, patch)
2015-01-25 09:53 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-01-25 09:53:15 PST
Created attachment 245308 [details] proposed fix
WebKit Commit Bot
Comment 2 2015-01-25 20:04:56 PST
Comment on attachment 245308 [details] proposed fix Clearing flags on attachment: 245308 Committed r179102: <http://trac.webkit.org/changeset/179102>
WebKit Commit Bot
Comment 3 2015-01-25 20:05:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.