Bug 140863

Summary: Setting HTMLMarqueeElement.trueSpeed doesn't work
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: DOMAssignee: Alexey Proskuryakov <ap>
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=15263
Bug Depends on:    
Bug Blocks: 140851    
Description Flags
proposed fix none

Description Alexey Proskuryakov 2015-01-25 00:50:36 PST
HTMLMarqueeElement.trueSpeed is a boolean property, so setting it it to true sets an empty value.

void Element::setBooleanAttribute(const QualifiedName& name, bool value)
    if (value)
        setAttribute(name, emptyAtom);

But then HTMLMarqueeElement::minimumDelay() treats an empty value as false.
Comment 1 Alexey Proskuryakov 2015-01-25 09:53:15 PST
Created attachment 245308 [details]
proposed fix
Comment 2 WebKit Commit Bot 2015-01-25 20:04:56 PST
Comment on attachment 245308 [details]
proposed fix

Clearing flags on attachment: 245308

Committed r179102: <http://trac.webkit.org/changeset/179102>
Comment 3 WebKit Commit Bot 2015-01-25 20:05:02 PST
All reviewed patches have been landed.  Closing bug.