Bug 140605

Summary: ES6: Support Array.of construction
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Dean Jackson
Reported 2015-01-18 21:29:11 PST
ES6: Support Array.of construction
Attachments
Patch (9.01 KB, patch)
2015-01-18 21:42 PST, Dean Jackson 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2015-01-18 21:29:51 PST
<rdar://problem/19513655>
Dean Jackson
Comment 2 2015-01-18 21:42:09 PST
Created attachment 244877 [details] Patch
Geoffrey Garen
Comment 3 2015-01-19 10:53:33 PST
Comment on attachment 244877 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244877&action=review r=me with two fixes below > Source/JavaScriptCore/runtime/ArrayConstructor.cpp:55 > + of arrayConstructorOf DontEnum|Function 1 Length should be 0, not 1. > Source/JavaScriptCore/runtime/ArrayConstructor.cpp:139 > + result->putDirectIndex(exec, i, args.at(i)); You should add a line to your testcase that verifies that Array.of does not invoke a setter for the index 0.
Eric Carlson
Comment 4 2015-01-19 10:57:41 PST
Comment on attachment 244877 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244877&action=review > Source/JavaScriptCore/ChangeLog:9 > + Add and implementation of Array.of, described in 22.1.2.3 of the ES6 Nit: "Add and" -> "Add an"
Dean Jackson
Comment 5 2015-01-19 13:40:41 PST
Committed r178662: <http://trac.webkit.org/changeset/178662>
Dean Jackson
Comment 6 2015-01-19 13:41:32 PST
(In reply to comment #4) > > Nit: "Add and" -> "Add an" Oops!
Joseph Pecoraro
Comment 7 2015-11-12 21:54:28 PST
*** Bug 131699 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.