Summary: | Remove the SVG instance tree | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philip Rogers <pdr> | ||||
Component: | SVG | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, cdumez, darin, dino, jeffrey+webkit, kling, rniwa, sabouhallawa, sam, thorton, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 140679, 140826, 140875, 140984, 141025, 141108, 141148, 141374 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Philip Rogers
2015-01-18 17:58:56 PST
Sounds good to me. I'm fine with this as well. I’m going to take a crack at this. Investigating crbug.com/313438 further, it’s clear this is a pretty big project that Rob Buis did! But we can indeed take advantage of those patches and redo this for WebKit; it will be 10 or so patches to do it all. I am about to land a first patch. Created attachment 246251 [details]
Patch
Committed r179810: <http://trac.webkit.org/changeset/179810> This may have caused a perf regression on the HTML5 full-render test: - https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D (Mavericks / 3.6% regression) - https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22efl%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D (EFL / 2.3% regression) I am not 100% sure it is caused by this change but the range on the EFL bot is small enough that I'd say it is very likely. (In reply to comment #7) > This may have caused a perf regression on the HTML5 full-render test: > - > https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac- > mavericks%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D (Mavericks / > 3.6% regression) > - > https://perf.webkit.org/ > #mode=charts&chartList=%5B%5B%22efl%22%2C%22Parser%2Fhtml5-full- > render%3ATime%22%5D%5D (EFL / 2.3% regression) > > I am not 100% sure it is caused by this change but the range on the EFL bot > is small enough that I'd say it is very likely. Looking at the change though, I really don't see what could have caused a regression. I think Ryosuke is planning to confirm the regression locally (may be a flake on the bot or another commit). Are there any SVG <use> elements in the full-render test? *** Bug 121050 has been marked as a duplicate of this bug. *** |