Bug 140599

Summary: Generate matchingShorthandsForLonghand() implementation from CSSPropertyNames.in
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, kling, koivisto, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 140501    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2015-01-18 15:53:53 PST 
We should generate matchingShorthandsForLonghand() implementation from CSSPropertyNames.in. We already have all the information we need in CSSPropertyNames.in to generate the big switch() in matchingShorthandsForLonghand().
Comment 1 Chris Dumez 2015-01-18 18:27:04 PST 
Created attachment 244870 [details]
Patch
Comment 2 Chris Dumez 2015-01-18 18:27:48 PST 
Comment on attachment 244870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244870&action=review

> Source/WebCore/css/makeprop.pl:991
>  print SHORTHANDS_CPP << "EOF";

The generated code looks like:
http://pastebin.com/j6nJ5FWg
Comment 3 WebKit Commit Bot 2015-01-18 18:28:28 PST 
Attachment 244870 [details] did not pass style-queue:


ERROR: Source/WebCore/css/StylePropertyShorthand.h:91:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/css/StylePropertyShorthand.h:94:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/css/StylePropertyShorthand.h:97:  Missing space before {  [whitespace/braces] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2015-01-18 20:51:30 PST 
Comment on attachment 244870 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2015-01-18 21:32:26 PST 
Comment on attachment 244870 [details]
Patch

Clearing flags on attachment: 244870

Committed r178638: <http://trac.webkit.org/changeset/178638>
Comment 6 WebKit Commit Bot 2015-01-18 21:32:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2016-04-29 09:20:35 PDT 
*** Bug 126049 has been marked as a duplicate of this bug. ***