Bug 140442

Summary:

Rename Font to FontCascade

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, darin, hyatt, mitz, mmaxfield, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

135290

Attachments:

Description	Flags
patch	darin: review+
for bots 2	none
another	none
another	none
another	none
another	none
another	none
another	none
patch	none
another	none

Antti Koivisto

Reported 2015-01-14 08:11:45 PST

We can then rename SimpleFontData to Font. This will match better the usual definition of "font".

Attachments
patch (383.41 KB, patch) 2015-01-14 08:15 PST, Antti Koivisto	darin: review+	Details Formatted Diff Diff
for bots 2 (391.00 KB, patch) 2015-01-14 15:37 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (392.38 KB, patch) 2015-01-14 15:46 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (390.62 KB, patch) 2015-01-15 02:21 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (391.33 KB, patch) 2015-01-15 02:53 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (405.68 KB, patch) 2015-01-15 03:31 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (408.99 KB, patch) 2015-01-15 04:03 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (411.76 KB, patch) 2015-01-15 05:39 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (412.92 KB, patch) 2015-01-15 05:50 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (414.35 KB, patch) 2015-01-15 06:03 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2015-01-14 08:15:44 PST

Created attachment 244604 [details] patch

WebKit Commit Bot

Comment 2 2015-01-14 08:17:37 PST

Attachment 244604 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/FontCascade.h:272: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/graphics/FontCascade.cpp:737: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FontCascade.cpp:738: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/graphics/FontCascade.cpp:817: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/platform/graphics/FontCascade.cpp:943: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 139 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 3 2015-01-14 08:55:51 PST

Comment on attachment 244604 [details] patch Need to update CMakeList.txt. Also, I agree with the style bot.

Antti Koivisto

Comment 4 2015-01-14 15:37:10 PST

Created attachment 244653 [details] for bots 2

Myles C. Maxfield

Comment 5 2015-01-14 15:42:27 PST

Oh my lord

Antti Koivisto

Comment 6 2015-01-14 15:46:04 PST

Created attachment 244655 [details] another

Antti Koivisto

Comment 7 2015-01-15 02:21:05 PST

Created attachment 244684 [details] another

Antti Koivisto

Comment 8 2015-01-15 02:53:15 PST

Created attachment 244685 [details] another

Antti Koivisto

Comment 9 2015-01-15 03:31:23 PST

Created attachment 244686 [details] another

WebKit Commit Bot

Comment 10 2015-01-15 03:43:55 PST

Attachment 244686 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/win/UniscribeController.h:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 1 in 149 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 11 2015-01-15 04:03:01 PST

Created attachment 244687 [details] another

WebKit Commit Bot

Comment 12 2015-01-15 04:05:44 PST

Attachment 244687 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/win/UniscribeController.h:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 1 in 151 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 13 2015-01-15 05:39:57 PST

Created attachment 244688 [details] another

Antti Koivisto

Comment 14 2015-01-15 05:50:02 PST

Created attachment 244689 [details] patch

Antti Koivisto

Comment 15 2015-01-15 06:03:11 PST

Created attachment 244690 [details] another

Antti Koivisto

Comment 16 2015-01-15 06:21:43 PST

https://trac.webkit.org/r178510