Bug 140315

Summary: Get rid of legacy StyleBuilder switch in StyleResolver.cpp
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2015-01-09 14:39:06 PST
Get rid of legacy StyleBuilder switch in StyleResolver.cpp. Most properties have been ported to the generated StyleBuilder already. The ones that remain are shorthand properties and other properties that do no require any StyleBuilder handling. We should be able to get rid of this switch by introducing a [SkipBuilder] parameter in CSSPropertyNames.in.
Attachments
Patch (44.80 KB, patch)
2015-01-09 15:21 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (44.81 KB, patch)
2015-01-09 15:58 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-09 15:21:10 PST
Created attachment 244377 [details] Patch
Chris Dumez
Comment 2 2015-01-09 15:58:27 PST
Created attachment 244382 [details] Patch
Sam Weinig
Comment 3 2015-01-09 17:08:08 PST
Comment on attachment 244382 [details] Patch Nice! r=me.
WebKit Commit Bot
Comment 4 2015-01-09 17:48:45 PST
Comment on attachment 244382 [details] Patch Clearing flags on attachment: 244382 Committed r178228: <http://trac.webkit.org/changeset/178228>
WebKit Commit Bot
Comment 5 2015-01-09 17:48:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.