Bug 140277

Summary: Add support for SVG CSS Properties to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, darin, kling, koivisto, rniwa, sabouhallawa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-mountainlion
none
Archive of layout-test-results from ews104 for mac-mountainlion-wk2
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2015-01-08 18:29:52 PST
Add support for SVG CSS Properties to the new StyleBuilder.
Attachments
Patch (25.05 KB, patch)
2015-01-08 20:23 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-mountainlion (936.61 KB, application/zip)
2015-01-08 21:25 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews104 for mac-mountainlion-wk2 (931.63 KB, application/zip)
2015-01-08 21:26 PST, Build Bot 		no flags
Details
Patch (27.59 KB, patch)
2015-01-08 22:02 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (27.53 KB, patch)
2015-01-08 22:07 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (27.55 KB, patch)
2015-01-08 23:41 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (27.56 KB, patch)
2015-01-09 11:11 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-08 20:23:03 PST
Created attachment 244320 [details] Patch
Build Bot
Comment 2 2015-01-08 21:25:54 PST
Comment on attachment 244320 [details] Patch Attachment 244320 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5089822087577600 New failing tests: svg/css/text-shadow-multiple.xhtml
Build Bot
Comment 3 2015-01-08 21:25:57 PST
Created attachment 244324 [details] Archive of layout-test-results from ews102 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 4 2015-01-08 21:26:15 PST
Comment on attachment 244320 [details] Patch Attachment 244320 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4741315690496000 New failing tests: svg/css/text-shadow-multiple.xhtml
Build Bot
Comment 5 2015-01-08 21:26:17 PST
Created attachment 244325 [details] Archive of layout-test-results from ews104 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Chris Dumez
Comment 6 2015-01-08 22:02:29 PST
Created attachment 244327 [details] Patch
Chris Dumez
Comment 7 2015-01-08 22:07:58 PST
Created attachment 244329 [details] Patch
Chris Dumez
Comment 8 2015-01-08 23:41:25 PST
Created attachment 244332 [details] Patch
Andreas Kling
Comment 9 2015-01-09 11:01:39 PST
Comment on attachment 244332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244332&action=review r=me > Source/WebCore/ChangeLog:26 > + conveter. Typo, converter. > Source/WebCore/css/StyleResolver.cpp:171 > +static const CSSPropertyID firstLowPriorityProperty = static_cast<CSSPropertyID>(CSSPropertyLineHeight + 1); Nice.
Chris Dumez
Comment 10 2015-01-09 11:11:25 PST
Created attachment 244352 [details] Patch
WebKit Commit Bot
Comment 11 2015-01-09 12:32:19 PST
Comment on attachment 244352 [details] Patch Clearing flags on attachment: 244352 Committed r178189: <http://trac.webkit.org/changeset/178189>
WebKit Commit Bot
Comment 12 2015-01-09 12:32:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.