Bug 140008

Summary: Move font-related CSS properties to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2014-12-30 12:46:02 PST
Move font-related CSS properties to the new StyleBuilder by teaching makeprop.pl how to generate them.
Attachments
Patch (16.70 KB, patch)
2014-12-30 13:14 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (17.00 KB, patch)
2014-12-30 14:31 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (17.00 KB, patch)
2014-12-30 16:01 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-12-30 13:14:57 PST
Created attachment 243828 [details] Patch
Chris Dumez
Comment 2 2014-12-30 14:31:27 PST
Created attachment 243830 [details] Patch
Darin Adler
Comment 3 2014-12-30 15:57:28 PST
Comment on attachment 243830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243830&action=review > Source/WebCore/css/CSSPropertyNames.in:101 > -webkit-font-kerning [Inherited, LegacyStyleBuilder] > -webkit-font-smoothing [Inherited, LegacyStyleBuilder] > +-webkit-font-kerning [Inherited, FontProperty, TypeName=FontDescription::Kerning, NameForMethods=Kerning] > +-webkit-font-smoothing [Inherited, FontProperty, TypeName=FontSmoothingMode] Build failed because you left in the old lines along with the new ones.
Chris Dumez
Comment 4 2014-12-30 16:00:19 PST
Comment on attachment 243830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243830&action=review >> Source/WebCore/css/CSSPropertyNames.in:101 >> +-webkit-font-smoothing [Inherited, FontProperty, TypeName=FontSmoothingMode] > > Build failed because you left in the old lines along with the new ones. I had a conflict when rebasing and messed up the merge. I'll fix now.
Chris Dumez
Comment 5 2014-12-30 16:01:47 PST
Created attachment 243832 [details] Patch
WebKit Commit Bot
Comment 6 2014-12-30 16:53:07 PST
Comment on attachment 243832 [details] Patch Clearing flags on attachment: 243832 Committed r177828: <http://trac.webkit.org/changeset/177828>
WebKit Commit Bot
Comment 7 2014-12-30 16:53:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.