| Summary: | Move font-related CSS properties to the new StyleBuilder | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, kling, koivisto, sam | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 137910 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2014-12-30 12:46:02 PST
Created attachment 243828 [details]
Patch
Created attachment 243830 [details]
Patch
Comment on attachment 243830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243830&action=review > Source/WebCore/css/CSSPropertyNames.in:101 > -webkit-font-kerning [Inherited, LegacyStyleBuilder] > -webkit-font-smoothing [Inherited, LegacyStyleBuilder] > +-webkit-font-kerning [Inherited, FontProperty, TypeName=FontDescription::Kerning, NameForMethods=Kerning] > +-webkit-font-smoothing [Inherited, FontProperty, TypeName=FontSmoothingMode] Build failed because you left in the old lines along with the new ones. Comment on attachment 243830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243830&action=review >> Source/WebCore/css/CSSPropertyNames.in:101 >> +-webkit-font-smoothing [Inherited, FontProperty, TypeName=FontSmoothingMode] > > Build failed because you left in the old lines along with the new ones. I had a conflict when rebasing and messed up the merge. I'll fix now. Created attachment 243832 [details]
Patch
Comment on attachment 243832 [details] Patch Clearing flags on attachment: 243832 Committed r177828: <http://trac.webkit.org/changeset/177828> All reviewed patches have been landed. Closing bug. |