| Summary: | Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, kling, koivisto, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 137910 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2014-12-30 11:15:01 PST
Created attachment 243827 [details]
Patch
Comment on attachment 243827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243827&action=review > Source/WebCore/css/StyleBuilderCustom.h:1262 > +#if !ASSERT_DISABLED Why is this #if needed? The else has only the assertion in it. Is this a pattern followed in other functions in this file? Comment on attachment 243827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243827&action=review >> Source/WebCore/css/StyleBuilderCustom.h:1262 >> +#if !ASSERT_DISABLED > > Why is this #if needed? The else has only the assertion in it. Is this a pattern followed in other functions in this file? I merely moved this code. I don't think this pattern is used elsewhere in this file. I will drop it as it likely builds fine without it. Created attachment 243829 [details]
Patch
Comment on attachment 243829 [details] Patch Clearing flags on attachment: 243829 Committed r177827: <http://trac.webkit.org/changeset/177827> All reviewed patches have been landed. Closing bug. |