Bug 140007

Summary: Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-12-30 11:15:01 PST
Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder.
Attachments
Patch (12.59 KB, patch)
2014-12-30 11:57 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.55 KB, patch)
2014-12-30 13:43 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-12-30 11:57:38 PST
Created attachment 243827 [details] Patch
Darin Adler
Comment 2 2014-12-30 12:51:48 PST
Comment on attachment 243827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243827&action=review > Source/WebCore/css/StyleBuilderCustom.h:1262 > +#if !ASSERT_DISABLED Why is this #if needed? The else has only the assertion in it. Is this a pattern followed in other functions in this file?
Chris Dumez
Comment 3 2014-12-30 12:57:16 PST
Comment on attachment 243827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243827&action=review >> Source/WebCore/css/StyleBuilderCustom.h:1262 >> +#if !ASSERT_DISABLED > > Why is this #if needed? The else has only the assertion in it. Is this a pattern followed in other functions in this file? I merely moved this code. I don't think this pattern is used elsewhere in this file. I will drop it as it likely builds fine without it.
Chris Dumez
Comment 4 2014-12-30 13:43:56 PST
Created attachment 243829 [details] Patch
WebKit Commit Bot
Comment 5 2014-12-30 14:25:36 PST
Comment on attachment 243829 [details] Patch Clearing flags on attachment: 243829 Committed r177827: <http://trac.webkit.org/changeset/177827>
WebKit Commit Bot
Comment 6 2014-12-30 14:25:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.