Bug 139858

Summary: Move "Auto" CSS properties to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2014-12-21 17:07:50 PST 
Move "Auto" CSS properties from DeprecatedStyleBuilder to the new StyleBuilder.
Comment 1 Chris Dumez 2014-12-21 17:44:34 PST 
Created attachment 243616 [details]
Patch
Comment 2 Sam Weinig 2014-12-21 19:28:13 PST 
Comment on attachment 243616 [details]
Patch

Instead of doing this as Custom=All, can we make the generator generate this?
Comment 3 Chris Dumez 2014-12-21 19:51:41 PST 
(In reply to comment #2)
> Comment on attachment 243616 [details]
> Patch
> 
> Instead of doing this as Custom=All, can we make the generator generate this?

Eventually, I think so (also the Font-related properties for e.g.). I was working on getting rid of DeprecatedStyleBuilder as soon as possible. Then I was planning to do a second pass and see how we can reduce the amount of Custom code.

I was thinking it would be easier to group similar properties and prioritize generating the larger groups once all the implementation is in one place.

If you disagree, I can take a look at generating these 6 properties already when I find some time.
Comment 4 Chris Dumez 2014-12-21 20:38:00 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 243616 [details]
> > Patch
> > 
> > Instead of doing this as Custom=All, can we make the generator generate this?
> 
> Eventually, I think so (also the Font-related properties for e.g.). I was
> working on getting rid of DeprecatedStyleBuilder as soon as possible. Then I
> was planning to do a second pass and see how we can reduce the amount of
> Custom code.
> 
> I was thinking it would be easier to group similar properties and prioritize
> generating the larger groups once all the implementation is in one place.
> 
> If you disagree, I can take a look at generating these 6 properties already
> when I find some time.

I am working on this right now. I'll probably leave out the column-gap property for now (i.e. use custom code) as it is a bit different as I don't think we should make the generator more complex for a single property.
Comment 5 Sam Weinig 2014-12-21 21:06:56 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 243616 [details]
> > Patch
> > 
> > Instead of doing this as Custom=All, can we make the generator generate this?
> 
> Eventually, I think so (also the Font-related properties for e.g.). I was
> working on getting rid of DeprecatedStyleBuilder as soon as possible. Then I
> was planning to do a second pass and see how we can reduce the amount of
> Custom code.
> 
> I was thinking it would be easier to group similar properties and prioritize
> generating the larger groups once all the implementation is in one place.
> 
> If you disagree, I can take a look at generating these 6 properties already
> when I find some time.

That seems reasonable.
Comment 6 Chris Dumez 2014-12-21 21:07:52 PST 
Comment on attachment 243616 [details]
Patch

I am almost done adding support for this in the generator.
Comment 7 Chris Dumez 2014-12-21 21:40:20 PST 
Created attachment 243619 [details]
Patch
Comment 8 Chris Dumez 2014-12-21 22:13:01 PST 
Comment on attachment 243619 [details]
Patch

now generating most properties.
Comment 9 WebKit Commit Bot 2014-12-22 02:39:01 PST 
Comment on attachment 243619 [details]
Patch

Clearing flags on attachment: 243619

Committed r177630: <http://trac.webkit.org/changeset/177630>
Comment 10 WebKit Commit Bot 2014-12-22 02:39:05 PST 
All reviewed patches have been landed.  Closing bug.