Bug 139827

Summary: Stop pretending that the LexicalEnvironment local var is captured
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 140093, 140097    
Bug Blocks: 139524    
Attachments:
Description Flags
the patch. none

Mark Lam
Reported 2014-12-19 12:12:11 PST
The current code pretends that the LexicalEnvironment local var is captured. This is a short cut to keeping that local var alive (even when it doesn't need to be). However, this pretense does have negative side-effects (see https://bugs.webkit.org/show_bug.cgi?id=139524). So, let's fix it.
Attachments
the patch. (1.38 KB, patch)
2015-01-05 12:40 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-12-19 12:14:35 PST
<rdar://problem/19311474>
Mark Lam
Comment 2 2015-01-05 12:40:52 PST
Created attachment 243988 [details] the patch. This patch is just to track the work being done. It is not ready for landing because applying this patch will expose other issues manifesting as esc-stress-test failures. Bugs tracking those issues will be documented shortly.
Mark Lam
Comment 3 2015-01-05 12:42:19 PST
(In reply to comment #2) > ... esc-stress-test failures. ... typo: /esc-stress-test/jsc-stress-test/
Mark Lam
Comment 4 2015-04-13 13:02:42 PDT
The offending code was deleted when CodeBlock::isCaptured() was deleted as part of the fix to https://bugs.webkit.org/show_bug.cgi?id=141174. So, I'll resolve this as a dup to 141174. *** This bug has been marked as a duplicate of bug 141174 ***
Note You need to log in before you can comment on or make changes to this bug.