Summary: | [Win] Correct Windows tests after Bug 139149 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Major | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Brent Fulgham
2014-12-18 10:57:53 PST
Created attachment 243506 [details]
Patch
Attachment 243506 [details] did not pass style-queue:
ERROR: Source/WebKit/win/WebApplicationCache.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKit/win/WebApplicationCache.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKit/win/WebApplicationCache.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 3 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 243507 [details]
Patch
Attachment 243507 [details] did not pass style-queue:
ERROR: Source/WebKit/win/WebApplicationCache.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKit/win/WebApplicationCache.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/WebKit/win/WebApplicationCache.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 3 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #4) > Attachment 243507 [details] did not pass style-queue: > > > ERROR: Source/WebKit/win/WebApplicationCache.cpp:26: Found other header > before WebCore config.h. Should be: config.h, primary header, blank line, > and then alphabetically sorted. [build/include_order] [4] > ERROR: Source/WebKit/win/WebApplicationCache.cpp:27: Found header this file > implements after other header. Should be: config.h, primary header, blank > line, and then alphabetically sorted. [build/include_order] [4] > ERROR: Source/WebKit/win/WebApplicationCache.cpp:32: Alphabetical sorting > problem. [build/include_order] [4] > Total errors found: 3 in 11 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. This ordering is required by the IDL build steps on Windows. Committed r177512: <http://trac.webkit.org/changeset/177512> |