Bug 139781 - [Win] Correct Windows tests after Bug 139149
Summary: [Win] Correct Windows tests after Bug 139149
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Major
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-18 10:57 PST by Brent Fulgham
Modified: 2014-12-18 11:56 PST (History)
1 user (show)

See Also:

Attachments
Patch (32.71 KB, patch)
2014-12-18 11:30 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (20.75 KB, patch)
2014-12-18 11:33 PST, Brent Fulgham 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-12-18 10:57:53 PST 
Some additional diagnostics were added in Bug 139149 that cause thousands of Windows tests to fail. This patch implements the missing function so that we can remove this warning and get the bots green again.
Comment 1 Brent Fulgham 2014-12-18 11:30:45 PST 
Created attachment 243506 [details]
Patch
Comment 2 WebKit Commit Bot 2014-12-18 11:32:12 PST 
Attachment 243506 [details] did not pass style-queue:


ERROR: Source/WebKit/win/WebApplicationCache.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/win/WebApplicationCache.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/win/WebApplicationCache.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brent Fulgham 2014-12-18 11:33:11 PST 
Created attachment 243507 [details]
Patch
Comment 4 WebKit Commit Bot 2014-12-18 11:35:11 PST 
Attachment 243507 [details] did not pass style-queue:


ERROR: Source/WebKit/win/WebApplicationCache.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/win/WebApplicationCache.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/win/WebApplicationCache.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brent Fulgham 2014-12-18 11:48:18 PST 
(In reply to comment #4)
> Attachment 243507 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebKit/win/WebApplicationCache.cpp:26:  Found other header
> before WebCore config.h. Should be: config.h, primary header, blank line,
> and then alphabetically sorted.  [build/include_order] [4]
> ERROR: Source/WebKit/win/WebApplicationCache.cpp:27:  Found header this file
> implements after other header. Should be: config.h, primary header, blank
> line, and then alphabetically sorted.  [build/include_order] [4]
> ERROR: Source/WebKit/win/WebApplicationCache.cpp:32:  Alphabetical sorting
> problem.  [build/include_order] [4]
> Total errors found: 3 in 11 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

This ordering is required by the IDL build steps on Windows.
Comment 6 Brent Fulgham 2014-12-18 11:56:47 PST 
Committed r177512: <http://trac.webkit.org/changeset/177512>