Bug 139149 - http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
Summary: http/tests/appcache/main-resource-fallback-for-network-error-crash.html can b...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Blocks: 138958
  Show dependency treegraph
Reported: 2014-12-01 13:57 PST by Alexey Proskuryakov
Modified: 2014-12-02 16:33 PST (History)
2 users (show)

See Also:

proposed fix (12.29 KB, patch)
2014-12-02 13:22 PST, Alexey Proskuryakov
andersca: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-12-01 13:57:23 PST
http/tests/appcache/main-resource-fallback-for-network-error-crash.html adds a fallback cache entry for <>, so any tests that simulate a failure and run after it get the fallback content instead. E.g.

run-webkit-tests --no-retry --child-processes=1 http/tests/appcache/main-resource-fallback-for-network-error-crash.html http/tests/misc/error404.pl
Comment 1 Alexey Proskuryakov 2014-12-02 13:22:30 PST
Created attachment 242443 [details]
proposed fix
Comment 2 WebKit Commit Bot 2014-12-02 16:05:13 PST
Comment on attachment 242443 [details]
proposed fix

Rejecting attachment 242443 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 242443, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/mac/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/4658292093616128
Comment 3 Alexey Proskuryakov 2014-12-02 16:33:21 PST
Committed <http://trac.webkit.org/r176698>.