Bug 139659

Summary: Web Inspector: Insertion bar (caret) is hidden behind the placeholder text in the style editor
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screenshot
none
Patch
none
Animated GIF with the patch applied none

Timothy Hatcher
Reported 2014-12-15 15:29:42 PST
Created attachment 243317 [details] Screenshot The placeholder should disappear on focus. It stays around until a character is typed.
Attachments
Screenshot (37.27 KB, image/png)
2014-12-15 15:29 PST, Timothy Hatcher 		no flags
Details
Patch (1.45 KB, patch)
2015-02-03 16:52 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Animated GIF with the patch applied (403.98 KB, image/gif)
2015-02-03 16:54 PST, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2014-12-15 15:37:06 PST
This does now match Yosemite, so I guess that is when it changed. But the insertion bar is hidden behind the first letter in the placeholder.
Joseph Pecoraro
Comment 2 2014-12-15 15:38:19 PST
I believe this matches system behavior (Mac OS X), but the appearance is certainly broken: (1) the Placeholder text is vertically off center (too high) (2) the Placeholder text is horizontally off, it overlaps the blinking caret, it should be moved over. Compare to <input placeholder="No Properties">.
Radar WebKit Bug Importer
Comment 3 2014-12-17 11:22:21 PST
<rdar://problem/19281508>
Radar WebKit Bug Importer
Comment 4 2014-12-17 11:26:25 PST
<rdar://problem/19281627>
Nikita Vasilyev
Comment 5 2015-02-03 16:52:57 PST
Created attachment 245987 [details] Patch
Nikita Vasilyev
Comment 6 2015-02-03 16:54:12 PST
Created attachment 245988 [details] Animated GIF with the patch applied
WebKit Commit Bot
Comment 7 2015-02-04 14:29:06 PST
Comment on attachment 245987 [details] Patch Clearing flags on attachment: 245987 Committed r179636: <http://trac.webkit.org/changeset/179636>
WebKit Commit Bot
Comment 8 2015-02-04 14:29:12 PST
All reviewed patches have been landed. Closing bug.
Nikita Vasilyev
Comment 9 2015-06-15 23:03:54 PDT
*** Bug 144028 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.