Bug 139659 - Web Inspector: Insertion bar (caret) is hidden behind the placeholder text in the style editor
Summary: Web Inspector: Insertion bar (caret) is hidden behind the placeholder text in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
: 144028 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-12-15 15:29 PST by Timothy Hatcher
Modified: 2015-06-15 23:03 PDT (History)
8 users (show)

See Also:

Attachments
Screenshot (37.27 KB, image/png)
2014-12-15 15:29 PST, Timothy Hatcher 		no flags Details
Patch (1.45 KB, patch)
2015-02-03 16:52 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Animated GIF with the patch applied (403.98 KB, image/gif)
2015-02-03 16:54 PST, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-12-15 15:29:42 PST 
Created attachment 243317 [details]
Screenshot

The placeholder should disappear on focus. It stays around until a character is typed.
Comment 1 Timothy Hatcher 2014-12-15 15:37:06 PST 
This does now match Yosemite, so I guess that is when it changed. But the insertion bar is hidden behind the first letter in the placeholder.
Comment 2 Joseph Pecoraro 2014-12-15 15:38:19 PST 
I believe this matches system behavior (Mac OS X), but the appearance is certainly broken:

  (1) the Placeholder text is vertically off center (too high)
  (2) the Placeholder text is horizontally off, it overlaps the blinking caret, it should be moved over.

Compare to <input placeholder="No Properties">.
Comment 3 Radar WebKit Bug Importer 2014-12-17 11:22:21 PST 
<rdar://problem/19281508>
Comment 4 Radar WebKit Bug Importer 2014-12-17 11:26:25 PST 
<rdar://problem/19281627>
Comment 5 Nikita Vasilyev 2015-02-03 16:52:57 PST 
Created attachment 245987 [details]
Patch
Comment 6 Nikita Vasilyev 2015-02-03 16:54:12 PST 
Created attachment 245988 [details]
Animated GIF with the patch applied
Comment 7 WebKit Commit Bot 2015-02-04 14:29:06 PST 
Comment on attachment 245987 [details]
Patch

Clearing flags on attachment: 245987

Committed r179636: <http://trac.webkit.org/changeset/179636>
Comment 8 WebKit Commit Bot 2015-02-04 14:29:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Nikita Vasilyev 2015-06-15 23:03:54 PDT 
*** Bug 144028 has been marked as a duplicate of this bug. ***