Bug 139635

Summary:

Move 'counter-increment' / 'counter-reset' to the new StyleBuilder

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

CSS

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, kling, koivisto, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

137910

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2014-12-14 21:03:48 PST

Move 'counter-increment' / 'counter-reset' to the new StyleBuilder

Comment 1 Chris Dumez 2014-12-14 21:41:39 PST

Created attachment 243281 [details]
Patch

Comment 2 Antti Koivisto 2014-12-15 01:16:20 PST

Comment on attachment 243281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243281&action=review

> Source/WebCore/css/StyleBuilderCustom.h:159
> +    template <CounterBehavior counterBehavior>
> +    static void applyInheritCounter(StyleResolver&);

I would put template arguments on the same line in headers.

Comment 3 WebKit Commit Bot 2014-12-15 01:49:40 PST

Comment on attachment 243281 [details]
Patch

Clearing flags on attachment: 243281

Committed r177274: <http://trac.webkit.org/changeset/177274>

Comment 4 WebKit Commit Bot 2014-12-15 01:49:44 PST

All reviewed patches have been landed.  Closing bug.