Bug 139516

Summary:

Switch to comparing PLATFORM_NAME in terms of macosx

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebKit Misc.

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, joepeck, mitz, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1 (Testing build; DO NOT REVIEW YET unless it passes)	none
Patch v2 (please review)	timothy: review+

David Kilzer (:ddkilzer)

Reported 2014-12-10 17:21:16 PST

Switch to comparing PLATFORM_NAME in terms of macosx instead of iOS SDK names. See also: Bug 138813: FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors Bug 139212: Switch from using PLATFORM_NAME to SDK selectors in ANGLE, bmalloc, gtest, JavaScriptCore, WTF Bug 139463: Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2

Attachments
Patch v1 (Testing build; DO NOT REVIEW YET unless it passes) (19.94 KB, patch) 2014-12-10 17:28 PST, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
Patch v2 (please review) (18.53 KB, patch) 2014-12-20 12:43 PST, David Kilzer (:ddkilzer)	timothy: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2014-12-10 17:28:52 PST

Created attachment 243082 [details] Patch v1 (Testing build; DO NOT REVIEW YET unless it passes)

David Kilzer (:ddkilzer)

Comment 2 2014-12-10 17:29:42 PST

Comment on attachment 243082 [details] Patch v1 (Testing build; DO NOT REVIEW YET unless it passes) View in context: https://bugs.webkit.org/attachment.cgi?id=243082&action=review > Source/WebKit/mac/migrate-headers.sh:32 > + export WEBCORE_PRIVATE_HEADERS_DIR="`eval 'echo ${WEBCORE_PRIVATE_HEADERS_DIR_Production}'`" This change really belongs with Bug 139516.

David Kilzer (:ddkilzer)

Comment 3 2014-12-20 12:43:27 PST

Created attachment 243607 [details] Patch v2 (please review)

Timothy Hatcher

Comment 4 2015-01-20 13:33:35 PST

Comment on attachment 243607 [details] Patch v2 (please review) View in context: https://bugs.webkit.org/attachment.cgi?id=243607&action=review > Source/WebKit/mac/MigrateHeaders.make:193 > -ifneq ($(filter iphoneos iphonesimulator, $(PLATFORM_NAME)), ) > +ifneq ($(filter macosx, $(PLATFORM_NAME)),macosx) I this correct? I would have expected ifneq to change to ifeq here. A space before the last macosx would be good too.

David Kilzer (:ddkilzer)

Comment 5 2015-01-20 13:46:33 PST

Comment on attachment 243607 [details] Patch v2 (please review) View in context: https://bugs.webkit.org/attachment.cgi?id=243607&action=review >> Source/WebKit/mac/MigrateHeaders.make:193 >> +ifneq ($(filter macosx, $(PLATFORM_NAME)),macosx) > > I this correct? I would have expected ifneq to change to ifeq here. A space before the last macosx would be good too. Will simplify this to the following before landing: ifneq ($(PLATFORM_NAME), macosx)

David Kilzer (:ddkilzer)

Comment 6 2015-01-20 13:49:52 PST

Committed r178753: <http://trac.webkit.org/changeset/178753>

mitz

Comment 7 2015-04-27 20:37:42 PDT

(In reply to comment #6) > Committed r178753: <http://trac.webkit.org/changeset/178753> This caused bug 144311.

Note You need to log in before you can comment on or make changes to this bug.