Summary: | Switch to comparing PLATFORM_NAME in terms of macosx | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aestes, joepeck, mitz, mrowe | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2014-12-10 17:21:16 PST
Created attachment 243082 [details]
Patch v1 (Testing build; DO NOT REVIEW YET unless it passes)
Comment on attachment 243082 [details] Patch v1 (Testing build; DO NOT REVIEW YET unless it passes) View in context: https://bugs.webkit.org/attachment.cgi?id=243082&action=review > Source/WebKit/mac/migrate-headers.sh:32 > + export WEBCORE_PRIVATE_HEADERS_DIR="`eval 'echo ${WEBCORE_PRIVATE_HEADERS_DIR_Production}'`" This change really belongs with Bug 139516. Created attachment 243607 [details]
Patch v2 (please review)
Comment on attachment 243607 [details] Patch v2 (please review) View in context: https://bugs.webkit.org/attachment.cgi?id=243607&action=review > Source/WebKit/mac/MigrateHeaders.make:193 > -ifneq ($(filter iphoneos iphonesimulator, $(PLATFORM_NAME)), ) > +ifneq ($(filter macosx, $(PLATFORM_NAME)),macosx) I this correct? I would have expected ifneq to change to ifeq here. A space before the last macosx would be good too. Comment on attachment 243607 [details] Patch v2 (please review) View in context: https://bugs.webkit.org/attachment.cgi?id=243607&action=review >> Source/WebKit/mac/MigrateHeaders.make:193 >> +ifneq ($(filter macosx, $(PLATFORM_NAME)),macosx) > > I this correct? I would have expected ifneq to change to ifeq here. A space before the last macosx would be good too. Will simplify this to the following before landing: ifneq ($(PLATFORM_NAME), macosx) Committed r178753: <http://trac.webkit.org/changeset/178753> (In reply to comment #6) > Committed r178753: <http://trac.webkit.org/changeset/178753> This caused bug 144311. |