Bug 139140

Summary: Take into consideration canvas drawing for throttling DOM timers
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CanvasAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, barraclough, commit-queue, esprehn+autocc, gyuyoung.kim, jimoase, kling, koivisto
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 139812    
Bug Blocks: 138292    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2014-12-01 11:32:26 PST
We should take into consideration canvas drawing for throttling DOM timers. This will: - Fix cases where the DOMTimer would be throttled even though it is drawing on a canvas (e.g. http://hint.fm/wind) - Use less CPU when the canvas being drawn onto is outside the viewport. Radar: <rdar://problem/19102218>
Attachments
Patch (12.63 KB, patch)
2014-12-01 12:35 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-12-01 12:35:39 PST
Created attachment 242329 [details] Patch
Andreas Kling
Comment 2 2014-12-01 15:27:21 PST
Comment on attachment 242329 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-12-01 16:09:32 PST
Comment on attachment 242329 [details] Patch Clearing flags on attachment: 242329 Committed r176609: <http://trac.webkit.org/changeset/176609>
WebKit Commit Bot
Comment 4 2014-12-01 16:09:38 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2014-12-02 00:06:02 PST
What was the reason to have this fixed in a new bug, not in bug 139054 where the problem was reported? It is usually best to associate fixes with original reports.
Alexey Proskuryakov
Comment 6 2014-12-02 00:08:27 PST
*** Bug 139054 has been marked as a duplicate of this bug. ***
Chris Dumez
Comment 7 2014-12-02 08:03:44 PST
(In reply to comment #5) > What was the reason to have this fixed in a new bug, not in bug 139054 where > the problem was reported? It is usually best to associate fixes with > original reports. Sorry, I was only aware of the radar. Otherwise I wouldn't have bothered to create a new report.
Note You need to log in before you can comment on or make changes to this bug.