Bug 139120

Summary: [EFL] Add eldbus to the library list
Product: WebKit Reporter: Jaehun Lim <ljaehun.lim>
Component: WebKit EFLAssignee: Jaehun Lim <ljaehun.lim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lucas.de.marchi, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 136355    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Jaehun Lim
Reported 2014-11-30 22:38:45 PST
Fix undefined reference errors for eldbus APIs. ../../Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:139: error: undefined reference to 'eldbus_init' ../../Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:159: error: undefined reference to 'eldbus_shutdown' ../../Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:182: error: undefined reference to 'eldbus_shutdown'
Attachments
Patch (1.54 KB, patch)
2014-11-30 22:40 PST, Jaehun Lim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jaehun Lim
Comment 1 2014-11-30 22:40:35 PST
Created attachment 242304 [details] Patch
Gyuyoung Kim
Comment 2 2014-11-30 22:49:34 PST
Comment on attachment 242304 [details] Patch I wonder why this build error didn't happen on Bug 136355's EFL EWS.
Ryuan Choi
Comment 3 2014-11-30 23:22:31 PST
(In reply to comment #1) > Created attachment 242304 [details] > Patch Thanks. Your patch is reasonable to me but I don't know why this is not happen on my PC. Do you use SHARED_CORE?
Jaehun Lim
Comment 4 2014-11-30 23:35:57 PST
Yes, I used SHARED_CORE at that time.
WebKit Commit Bot
Comment 5 2014-11-30 23:36:21 PST
Comment on attachment 242304 [details] Patch Clearing flags on attachment: 242304 Committed r176590: <http://trac.webkit.org/changeset/176590>
WebKit Commit Bot
Comment 6 2014-11-30 23:36:25 PST
All reviewed patches have been landed. Closing bug.
Gyuyoung Kim
Comment 7 2014-12-01 00:09:45 PST
(In reply to comment #4) > Yes, I used SHARED_CORE at that time. Ah, that's why EFL EWS didn't detect this build break. EFL buildbots and EWS don't use SHARED_CORE option.
Gyuyoung Kim
Comment 8 2014-12-01 00:10:20 PST
(In reply to comment #7) > (In reply to comment #4) > > Yes, I used SHARED_CORE at that time. > > Ah, that's why EFL EWS didn't detect this build break. EFL buildbots and EWS > don't use SHARED_CORE option. It would be nicer if you mention this break occurs when SHARED_CORE is ON.
Note You need to log in before you can comment on or make changes to this bug.