Bug 139104

Summary: Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '-webkit-justify-self' and '-webkit-perspective' CSS properties to the new StyleBuilder
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2014-11-29 15:45:16 PST
Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '-webkit-justify-self' and '-webkit-perspective' CSS properties to the new StyleBuilder
Attachments
Patch (10.81 KB, patch)
2014-11-29 15:45 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2014-11-29 15:45:52 PST
Created attachment 242283 [details] Patch
WebKit Commit Bot
Comment 2 2014-11-29 16:38:56 PST
Comment on attachment 242283 [details] Patch Clearing flags on attachment: 242283 Committed r176584: <http://trac.webkit.org/changeset/176584>
WebKit Commit Bot
Comment 3 2014-11-29 16:38:59 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 4 2015-01-04 14:17:30 PST
Comment on attachment 242283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242283&action=review > Source/WebCore/css/StyleBuilderCustom.h:677 > + styleResolver.setTextOrientation(downcast<CSSPrimitiveValue>(value)); This does not need custom code, this is the default StyleBuilder behavior. I'll take care of removing this handler.
Chris Dumez
Comment 5 2015-01-04 16:07:21 PST
Comment on attachment 242283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242283&action=review >> Source/WebCore/css/StyleBuilderCustom.h:677 >> + styleResolver.setTextOrientation(downcast<CSSPrimitiveValue>(value)); > > This does not need custom code, this is the default StyleBuilder behavior. I'll take care of removing this handler. Ah, never mind, I have just noticed the setter is on StyleResolver, not RenderStyle.
Note You need to log in before you can comment on or make changes to this bug.