| Summary: | Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '-webkit-justify-self' and '-webkit-perspective' CSS properties to the new StyleBuilder | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 137910 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2014-11-29 15:45:16 PST
Created attachment 242283 [details]
Patch
Comment on attachment 242283 [details] Patch Clearing flags on attachment: 242283 Committed r176584: <http://trac.webkit.org/changeset/176584> All reviewed patches have been landed. Closing bug. Comment on attachment 242283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242283&action=review > Source/WebCore/css/StyleBuilderCustom.h:677 > + styleResolver.setTextOrientation(downcast<CSSPrimitiveValue>(value)); This does not need custom code, this is the default StyleBuilder behavior. I'll take care of removing this handler. Comment on attachment 242283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242283&action=review >> Source/WebCore/css/StyleBuilderCustom.h:677 >> + styleResolver.setTextOrientation(downcast<CSSPrimitiveValue>(value)); > > This does not need custom code, this is the default StyleBuilder behavior. I'll take care of removing this handler. Ah, never mind, I have just noticed the setter is on StyleResolver, not RenderStyle. |