Bug 139081

Summary: [WK2] SecComp buildfix after r176452
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: andersca, commit-queue, koivisto, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 139239    
Bug Blocks: 138963    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2014-11-27 13:42:03 PST
https://trac.webkit.org/changeset/176452 broke the seccomp build: ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:208:9: error: no matching function for call to 'sendMessage' if (sendMessage(m_socket, encoder->buffer(), encoder->bufferSize()) < 0) ^~~~~~~~~~~ ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:71:16: note: candidate function not viable: no known conversion from 'const uint8_t *' (aka 'const unsigned char *') to 'void *' for 2nd argument static ssize_t sendMessage(int socket, void* data, size_t size, int fd = -1) ^ ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:343:13: error: no matching function for call to 'sendMessage' if (sendMessage(socket, encoder->buffer(), encoder->bufferSize(), fd) < 0) ^~~~~~~~~~~ ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompBroker.cpp:71:16: note: candidate function not viable: no known conversion from 'const uint8_t *' (aka 'const unsigned char *') to 'void *' for 2nd argument static ssize_t sendMessage(int socket, void* data, size_t size, int fd = -1) ^ 2 errors generated.
Attachments
Patch (1.87 KB, patch)
2014-11-27 13:45 PST, Csaba Osztrogonác
no flags
Csaba Osztrogonác
Comment 1 2014-11-27 13:45:53 PST
WebKit Commit Bot
Comment 2 2014-11-28 01:10:25 PST
Comment on attachment 242258 [details] Patch Clearing flags on attachment: 242258 Committed r176559: <http://trac.webkit.org/changeset/176559>
WebKit Commit Bot
Comment 3 2014-11-28 01:10:29 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 4 2014-12-03 16:08:49 PST
Re-opened since this is blocked by bug 139239
Csaba Osztrogonác
Comment 5 2016-05-10 08:12:54 PDT
There is no seccomp in WebKit anymore, let's close it.
Note You need to log in before you can comment on or make changes to this bug.