| Summary: | Use std::unique_ptr instead of OwnPtr in JSC classes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
| Component: | JavaScriptCore | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, fpizlo | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 128007 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Gyuyoung Kim
2014-11-22 18:16:02 PST
Created attachment 242127 [details]
Patch
Created attachment 242132 [details]
Patch
CC'ing Filip, could you take a look this patch ? (It was hard to ping you on IRC. So I add you to CC) Pizlo, could you take a look this as well ? Comment on attachment 242132 [details] Patch Rejecting attachment 242132 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 242132, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: vaScriptCore/inspector/ContentSearchUtilities.cpp.rej patching file Source/JavaScriptCore/runtime/RegExp.cpp patching file Source/JavaScriptCore/runtime/RegExp.h patching file Source/JavaScriptCore/yarr/RegularExpression.cpp patching file Source/JavaScriptCore/yarr/YarrInterpreter.cpp patching file Source/JavaScriptCore/yarr/YarrInterpreter.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6042494890409984 Created attachment 242227 [details]
Patch for landing
Comment on attachment 242227 [details] Patch for landing Rejecting attachment 242227 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242227, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t.org/repository/webkit/trunk ... Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Password for 'commit-queue@webkit.org': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114. error: git-svn died of signal 11 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/4572464151527424 Comment on attachment 242227 [details] Patch for landing Clearing flags on attachment: 242227 Committed r176553: <http://trac.webkit.org/changeset/176553> All reviewed patches have been landed. Closing bug. |