Bug 138938

Summary: Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138766, 138999    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-11-20 15:10:39 PST
Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' to the new StyleBuilder
Attachments
Patch (64.22 KB, patch)
2014-11-20 15:18 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.55 KB, patch)
2014-12-01 14:39 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-11-20 15:18:00 PST
Created attachment 241990 [details] Patch
Chris Dumez
Comment 2 2014-11-20 16:13:34 PST
Comment on attachment 241990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241990&action=review > Source/WebCore/css/StyleBuilderCustom.h:-41 > -namespace StyleBuilderFunctions { Most of this is just changing the code indentation because I transformed the namespace into a class, and moving the code around to distinguish public and private functions. I will point out which methods are actually new. > Source/WebCore/css/StyleBuilderCustom.h:445 > + static void applyInitialTextShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:450 > + static void applyInheritTextShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:455 > + static void applyValueTextShadow(StyleResolver& styleResolver, CSSValue& value) This is new. > Source/WebCore/css/StyleBuilderCustom.h:460 > + static void applyInitialBoxShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:465 > + static void applyInheritBoxShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:470 > + static void applyValueBoxShadow(StyleResolver& styleResolver, CSSValue& value) This is new. > Source/WebCore/css/StyleBuilderCustom.h:475 > + static void applyInitialWebkitBoxShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:480 > + static void applyInheritWebkitBoxShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:485 > + static void applyValueWebkitBoxShadow(StyleResolver& styleResolver, CSSValue& value) This is new. > Source/WebCore/css/StyleBuilderCustom.h:500 > + static void applyTextOrBoxShadowValue(StyleResolver& styleResolver, CSSValue& value) This is new.
Sam Weinig
Comment 3 2014-11-20 20:39:01 PST
Comment on attachment 241990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241990&action=review > Source/WebCore/css/StyleBuilderCustom.h:504 > + styleResolver.style()->setTextShadow(nullptr); What about box shadow here?
Chris Dumez
Comment 4 2014-12-01 14:39:05 PST
Created attachment 242345 [details] Patch
WebKit Commit Bot
Comment 5 2014-12-01 18:16:30 PST
Comment on attachment 242345 [details] Patch Clearing flags on attachment: 242345 Committed r176621: <http://trac.webkit.org/changeset/176621>
WebKit Commit Bot
Comment 6 2014-12-01 18:16:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.