Summary: | Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' to the new StyleBuilder | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue, kling, koivisto, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 138766, 138999 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Chris Dumez
2014-11-20 15:10:39 PST
Created attachment 241990 [details]
Patch
Comment on attachment 241990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241990&action=review > Source/WebCore/css/StyleBuilderCustom.h:-41 > -namespace StyleBuilderFunctions { Most of this is just changing the code indentation because I transformed the namespace into a class, and moving the code around to distinguish public and private functions. I will point out which methods are actually new. > Source/WebCore/css/StyleBuilderCustom.h:445 > + static void applyInitialTextShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:450 > + static void applyInheritTextShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:455 > + static void applyValueTextShadow(StyleResolver& styleResolver, CSSValue& value) This is new. > Source/WebCore/css/StyleBuilderCustom.h:460 > + static void applyInitialBoxShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:465 > + static void applyInheritBoxShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:470 > + static void applyValueBoxShadow(StyleResolver& styleResolver, CSSValue& value) This is new. > Source/WebCore/css/StyleBuilderCustom.h:475 > + static void applyInitialWebkitBoxShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:480 > + static void applyInheritWebkitBoxShadow(StyleResolver& styleResolver) This is new. > Source/WebCore/css/StyleBuilderCustom.h:485 > + static void applyValueWebkitBoxShadow(StyleResolver& styleResolver, CSSValue& value) This is new. > Source/WebCore/css/StyleBuilderCustom.h:500 > + static void applyTextOrBoxShadowValue(StyleResolver& styleResolver, CSSValue& value) This is new. Comment on attachment 241990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241990&action=review > Source/WebCore/css/StyleBuilderCustom.h:504 > + styleResolver.style()->setTextShadow(nullptr); What about box shadow here? Created attachment 242345 [details]
Patch
Comment on attachment 242345 [details] Patch Clearing flags on attachment: 242345 Committed r176621: <http://trac.webkit.org/changeset/176621> All reviewed patches have been landed. Closing bug. |