Bug 138813

Summary:

FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebKit Misc.

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

burg, commit-queue, dino, joepeck, mrowe, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

139286

Attachments:

Description	Flags
Patch v1	none

David Kilzer (:ddkilzer)

Reported 2014-11-17 16:45:50 PST

Instead of using PLATFORM_NAME to define features in FeatureDefines.xcconfig, we should use [sdk=*] selectors since they are less verbose and more concise.

Attachments
Patch v1 (100.32 KB, patch) 2014-11-18 12:44 PST, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2014-11-18 12:44:44 PST

Created attachment 241805 [details] Patch v1

WebKit Commit Bot

Comment 2 2014-11-18 18:42:46 PST

Comment on attachment 241805 [details] Patch v1 Clearing flags on attachment: 241805 Committed r176303: <http://trac.webkit.org/changeset/176303>

WebKit Commit Bot

Comment 3 2014-11-18 18:42:50 PST

All reviewed patches have been landed. Closing bug.

David Kilzer (:ddkilzer)

Comment 4 2014-12-04 21:14:16 PST

(In reply to comment #2) > Comment on attachment 241805 [details] > Patch v1 > > Clearing flags on attachment: 241805 > > Committed r176303: <http://trac.webkit.org/changeset/176303> Filed this follow-up bug to track landing a workaround for 10.8 systems with Xcode 5.1.1: Bug 139286: FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY

Note You need to log in before you can comment on or make changes to this bug.