| Summary: | Move WebCore/loader to std::unique_ptr | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> |
| Component: | WebCore Misc. | Assignee: | Gyuyoung Kim <gyuyoung.kim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, japhet, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 128007 | ||
| Attachments: | |||
|
Description
Gyuyoung Kim
2014-11-11 18:01:12 PST
Created attachment 241403 [details]
Patch
*** Bug 138645 has been marked as a duplicate of this bug. *** Created attachment 241414 [details]
Patch
Created attachment 241453 [details]
Patch
Comment on attachment 241453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241453&action=review r=me with nits. > Source/WebCore/ChangeLog:12 > + No new tests, no behaviro changes. "behavior" > Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1362 > + std::unique_ptr<ApplicationCacheGroup> groupCopy(std::make_unique<ApplicationCacheGroup>(cache->group()->manifestURL(), true)); Don't we usually use "auto groupCopy = make_unique<>(...);" in such cases? Created attachment 241459 [details]
Patch for landing
(In reply to comment #5) > Comment on attachment 241453 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241453&action=review > > r=me with nits. > > > Source/WebCore/ChangeLog:12 > > + No new tests, no behaviro changes. > > "behavior" Oops, fixed. > > Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1362 > > + std::unique_ptr<ApplicationCacheGroup> groupCopy(std::make_unique<ApplicationCacheGroup>(cache->group()->manifestURL(), true)); > > Don't we usually use "auto groupCopy = make_unique<>(...);" in such cases? Why not ? It looks like this style is more clear. Fixed. Comment on attachment 241459 [details] Patch for landing Rejecting attachment 241459 [details] from commit-queue. Number of test failures exceeded the failure limit. Full output: http://webkit-queues.appspot.com/results/6591204879761408 Created attachment 241523 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 241459 [details] Patch for landing Attachment 241459 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5228930374041600 Number of test failures exceeded the failure limit. Created attachment 241528 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 241538 [details]
Patch for mac ews
Comment on attachment 241538 [details] Patch for mac ews Attachment 241538 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6120512971341824 New failing tests: http/tests/appcache/document-write-html-element.html http/tests/security/beforeload-iframe-client-redirect.html http/tests/appcache/cyrillic-uri.html http/tests/appcache/online-whitelist.html http/tests/cache/cache-redirections.html http/tests/appcache/history-test.html http/tests/appcache/crash-when-navigating-away-then-back.html http/tests/appcache/navigating-away-while-cache-attempt-in-progress.html http/tests/appcache/max-size.html http/tests/appcache/origin-quota.html http/tests/appcache/top-frame-1.html http/tests/appcache/whitelist-wildcard.html http/tests/appcache/disabled.html http/tests/appcache/main-resource-fallback-for-network-error-crash.html http/tests/appcache/reload.html http/tests/appcache/foreign-iframe-main.html http/tests/appcache/main-resource-redirect.html http/tests/appcache/local-content.html http/tests/appcache/top-frame-3.html http/tests/appcache/resource-redirect-2.html http/tests/appcache/wrong-signature-2.html http/tests/appcache/manifest-parsing.html http/tests/appcache/origin-quota-continued-download-multiple-manifests.html http/tests/appcache/origins-with-appcache.html http/tests/appcache/update-cache.html http/tests/appcache/offline-access.html http/tests/security/cross-origin-appcache.html http/tests/appcache/fallback.html Created attachment 241551 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 241538 [details] Patch for mac ews Attachment 241538 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4595611676442624 Number of test failures exceeded the failure limit. Created attachment 241553 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 241692 [details]
Patch for landing
Comment on attachment 241692 [details] Patch for landing Clearing flags on attachment: 241692 Committed r176172: <http://trac.webkit.org/changeset/176172> All reviewed patches have been landed. Closing bug. |