Bug 138540 – commit-queue dies if a non-committer sets cq+ flag

• Component: Tools / Tests
• Status: NEW

[Alexey Proskuryakov]

I suspect that this started with Bugzilla upgrade. Here is the error:

Traceback (most recent call last):
 File "/Volumes/Data/Feeder/Webkit/Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 101, in run
   if not self._delegate.process_work_item(work_item):
 File "/Volumes/Data/Feeder/Webkit/Tools/Scripts/webkitpy/tool/commands/queues.py", line 196, in process_work_item
   feeder.feed()
 File "/Volumes/Data/Feeder/Webkit/Tools/Scripts/webkitpy/tool/bot/feeders.py", line 54, in feed
   patches = self._validate_patches()
 File "/Volumes/Data/Feeder/Webkit/Tools/Scripts/webkitpy/tool/bot/feeders.py", line 75, in _validate_patches
   return self.committer_validator.patches_after_rejecting_invalid_commiters_and_reviewers(all_patches)
 File "/Volumes/Data/Feeder/Webkit/Tools/Scripts/webkitpy/common/config/committervalidator.py", line 74, in patches_after_rejecting_invalid_commiters_and_reviewers
   return [patch for patch in patches if self._reject_patch_if_flags_are_invalid(patch)]
 File "/Volumes/Data/Feeder/Webkit/Tools/Scripts/webkitpy/common/config/committervalidator.py", line 71, in _reject_patch_if_flags_are_invalid
   and self._validate_setter_email(patch, "committer", self.reject_patch_from_commit_queue))
 File "/Volumes/Data/Feeder/Webkit/Tools/Scripts/webkitpy/common/config/committervalidator.py", line 65, in _validate_setter_email
   rejection_function(patch.id(), self._flag_permission_rejection_message(setter_email, result_key))
 File "/Volumes/Data/Feeder/Webkit/Tools/Scripts/webkitpy/common/config/committervalidator.py", line 85, in reject_patch_from_commit_queue
   comment_text)
 File "/Volumes/Data/Feeder/Webkit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 774, in set_flag_on_attachment
   self.browser.set_value(comment_text, name='comment', nr=0)
 File "/Volumes/Data/Feeder/Webkit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 2833, in set_value
   c.value = value
 File "/Volumes/Data/Feeder/Webkit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 1221, in __setattr__
   raise AttributeError("control '%s' is disabled" % self.name)
AttributeError: control 'comment' is disabled

We probably need one or both of these fixes to be made more generic:


------------------------------------------------------------------------
r174800 | [e-mail] | 2014-10-16 16:55:59 -0700 (Thu, 16 Oct 2014) | 10 lines

commit-queue: fails to replace OO-PS! with reviewer name
<http://webkit.org/b/137795>

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
email addresses to unauthenticated page loads, so we must always
authenticate before getting bug data so we get full email
addresses.
------------------------------------------------------------------------
r174797 | [e-mail] | 2014-10-16 15:43:02 -0700 (Thu, 16 Oct 2014) | 9 lines

commit-queue: fails to close bugs after successfully landing patches
<http://webkit.org/b/137794>

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
tell Mechanize to use the second <textarea> on the page with
name="comment".