Bug 137794 - commit-queue: fails to close bugs after successfully landing patches
Summary: commit-queue: fails to close bugs after successfully landing patches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-16 15:29 PDT by David Kilzer (:ddkilzer)
Modified: 2014-10-16 15:43 PDT (History)
5 users (show)

See Also:


Attachments
Patch v1 (1.57 KB, patch)
2014-10-16 15:38 PDT, David Kilzer (:ddkilzer)
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-10-16 15:29:21 PDT
See:  <https://webkit-queues.appspot.com/results/5533208674304000>

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 239956, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Fetching: https://bugs.webkit.org/attachment.cgi?id=239956&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=137596&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 239956 from bug 137596.
Committed r174789: <http://trac.webkit.org/changeset/174789>
Logging in as commit-queue@webkit.org...
Clearing flags on attachment: 239956

Committed r174789: <http://trac.webkit.org/changeset/174789>
Updating OpenSource
From git://git.webkit.org/WebKit
   4fe827b..628d098  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 174785 = 4fe827b6bb38580831ecab29dfbc8e7d34c6726e
r174786 = 8bcf22ac234e7deecdb35407e3d2a1c83d737ec9
r174787 = a5d9cf509e7f2d0101af9cd1ae889cf9ad9951f0
r174788 = 628d0989d0fd2bcea2b7917e9e18ccb6bbd4922e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Traceback (most recent call last):
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/download.py", line 177, in execute
    self._process_patch(patch, options, args, tool)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/download.py", line 203, in _process_patch
    self._main_sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/closepatch.py", line 36, in run
    self._tool.bugs.clear_attachment_flags(state["patch"].id(), comment_text)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 757, in clear_attachment_flags
    self.browser.set_value(comment_text, name='comment', nr=0)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 2833, in set_value
    c.value = value
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 1221, in __setattr__
    raise AttributeError("control '%s' is disabled" % self.name)
AttributeError: control 'comment' is disabled
Comment 1 David Kilzer (:ddkilzer) 2014-10-16 15:31:45 PDT
Using Web Inspector, it looks like there are two <textarea> elements with the name "comment", and Mechanize is choosing the first one:

Load: <https://bugs.webkit.org/attachment.cgi?id=239956&action=edit>

#1: <textarea name="comment" id="editFrame" class="bz_default_hidden" wrap="soft" disabled="disabled" rows="10" cols="80">

#2: <textarea name="comment" id="comment" wrap="soft" rows="10" cols="80">

I think changing line 757 in bugzilla.py will fix this:

-        self.browser.set_value(comment_text, name='comment', nr=0)
+        self.browser.set_value(comment_text, name='comment', nr=1)
Comment 2 David Kilzer (:ddkilzer) 2014-10-16 15:38:20 PDT
Created attachment 239979 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2014-10-16 15:43:59 PDT
Committed r174797: <http://trac.webkit.org/changeset/174797>