RESOLVED FIXED 137795
commit-queue: fails to replace OO-PS! with reviewer name
https://bugs.webkit.org/show_bug.cgi?id=137795
Summary commit-queue: fails to replace OO-PS! with reviewer name
David Kilzer (:ddkilzer)
Reported 2014-10-16 15:51:49 PDT
After the Bugzilla 4.2.11 update, the commit-queue sometimes fails to replace the OO-PS! text with the reviewer name. For example: <https://webkit-queues.appspot.com/patch/239923> <https://webkit-queues.appspot.com/results/5777270190899200> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 239923, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Attachments
Patch v1 (1.69 KB, patch)
2014-10-16 16:50 PDT, David Kilzer (:ddkilzer)
ap: review+
David Kilzer (:ddkilzer)
Comment 1 2014-10-16 16:16:01 PDT
Oliver thinks this may be the same issue: $ ./Tools/Scripts/webkit-patch land 137766 Fetching: https://bugs.webkit.org/show_bug.cgi?id=137766&ctype=xml&excludefield=attachmentdata Warning, attachment 239923 [details] on bug 137766 has invalid reviewer (akling) No reviewed patches on bug 137766, cannot infer reviewer. Failed to guess reviewer from bug 137766 and --reviewer= not provided. Not updating ChangeLogs with reviewer. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Looks like webkit-patch isn't able to fetch the reviewer list?
David Kilzer (:ddkilzer)
Comment 2 2014-10-16 16:38:41 PDT
(In reply to comment #1) > Looks like webkit-patch isn't able to fetch the reviewer list? Bugzilla changed to not expose email addresses when no one is logged in, so webkit-patch is loading this URL without logging in first: https://bugs.webkit.org/show_bug.cgi?id=137766&ctype=xml&excludefield=attachmentdata And getting <flag> elements like this: <flag name="review" id="264671" type_id="1" status="+" setter="akling"/> <flag name="commit-queue" id="264709" type_id="3" status="+" setter="cdumez"/> Instead of like this (after logging in): <flag name="review" id="264671" type_id="1" status="+" setter="akling@apple.com"/> <flag name="commit-queue" id="264709" type_id="3" status="+" setter="cdumez@apple.com"/> The fix is to make sure webkit-patch logs in before fetching attachment data.
David Kilzer (:ddkilzer)
Comment 3 2014-10-16 16:50:52 PDT
Created attachment 239983 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 4 2014-10-16 16:56:34 PDT
David Kilzer (:ddkilzer)
Comment 5 2014-10-16 16:57:08 PDT
(In reply to comment #4) > Committed r174800: <http://trac.webkit.org/changeset/174800> NOTE: I haven't been able to verify if this is the only fix needed, but this is needed before we determine what the next issue is.
Note You need to log in before you can comment on or make changes to this bug.