Summary: | [GTK] Expose user script messages to GObject DOM bindings | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Bindings | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, gustavo, pnormand | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 138409 | ||||||
Bug Blocks: | 125775 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-11-05 00:44:27 PST
Created attachment 241009 [details]
Patch
The "raw" API is not very convenient to use, we should add custom API to make it easier to use.
Comment on attachment 241009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241009&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1586 > + return scalar(grep {$_ eq $domClassName} qw(WebKitDOMDOMWindow WebKitDOMUserMessageHandlersNamespace)); Kind of sad to hardcode this here :( Is this the only way? (In reply to comment #2) > Comment on attachment 241009 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241009&action=review > > > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1586 > > + return scalar(grep {$_ eq $domClassName} qw(WebKitDOMDOMWindow WebKitDOMUserMessageHandlersNamespace)); > > Kind of sad to hardcode this here :( Is this the only way? Not easily. When generating code, we know which symbols are not stable (the ones not in the stable symbols list), but custom symbols are not generated but manually implemented. The code generator knows which symbols require a custom implementation, but it doesn't know which custom symbols are actually implemented manually (most of them are simply not implemented). Comment on attachment 241009 [details]
Patch
Ok then.
Committed r176018: <http://trac.webkit.org/changeset/176018> |