Bug 138398

Summary: Move text-align CSS property to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, kling, koivisto, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2014-11-04 18:35:40 PST 
Move text-align CSS property to the new StyleBuilder
Comment 1 Chris Dumez 2014-11-04 19:09:39 PST 
Created attachment 240997 [details]
Patch
Comment 2 Antti Koivisto 2014-11-05 05:09:11 PST 
Comment on attachment 240997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240997&action=review

> Source/WebCore/css/StyleBuilderConverter.h:318
> +    if (styleResolver.parentStyle()->textAlign() == TASTART)

could use variable for styleResolver.parentStyle()->textAlign()
Comment 3 Chris Dumez 2014-11-05 09:28:49 PST 
Created attachment 241035 [details]
Patch
Comment 4 WebKit Commit Bot 2014-11-05 10:24:52 PST 
Comment on attachment 241035 [details]
Patch

Clearing flags on attachment: 241035

Committed r175625: <http://trac.webkit.org/changeset/175625>
Comment 5 WebKit Commit Bot 2014-11-05 10:24:58 PST 
All reviewed patches have been landed.  Closing bug.