Summary: | Move 'size' CSS property to the new StyleBuilder | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, commit-queue, kling, koivisto, rniwa, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 137910 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Chris Dumez
2014-11-03 17:10:30 PST
Created attachment 240885 [details]
Patch
Comment on attachment 240885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240885&action=review > Source/WebCore/css/StyleBuilderCustom.h:236 > +inline void applyInheritSize(StyleResolver&) { } > +inline void applyInitialSize(StyleResolver&) { } What's this about? Comment on attachment 240885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240885&action=review > Source/WebCore/css/StyleBuilderCustom.h:236 > +inline void applyInheritSize(StyleResolver&) { } > +inline void applyInitialSize(StyleResolver&) { } What's this about? Comment on attachment 240885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240885&action=review > Source/WebCore/css/DeprecatedStyleBuilder.cpp:-1339 > - static void applyInheritValue(CSSPropertyID, StyleResolver*) { } I moved the code from here, applyInitial and applyInherit were not doing anything but they need to be defined for the style builder code to build. Comment on attachment 240885 [details]
Patch
r=me
Created attachment 241082 [details]
Patch
Comment on attachment 241082 [details] Patch Clearing flags on attachment: 241082 Committed r175659: <http://trac.webkit.org/changeset/175659> All reviewed patches have been landed. Closing bug. |