Bug 138296

Summary: Move -webkit-shape-outside to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, betravis, buildbot, commit-queue, kling, koivisto, rniwa, sam, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-11-02 16:00:19 PST
Move -webkit-shape-outside to the new StyleBuilder.
Attachments
Patch (9.10 KB, patch)
2014-11-02 16:33 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.98 KB, patch)
2014-11-03 09:03 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-11-02 16:03:10 PST
Bear, Zoltan, when looking at the ApplyPropertyShape<> code in DeprecatedStyleBuilder.cpp, I noticed that it is handling only CSSValueAuto as CSSPrimitiveValue. This does not seem right. The spec (and our CSS Parser) only seem to allow CSSValueNone as CSSPrimitiveValue. Should we update ApplyPropertyShape<> to all setShapeOutside(style, nullptr) when the value is CSSValueNone? (instead of CSSValueAuto).
Chris Dumez
Comment 2 2014-11-02 16:33:18 PST
Created attachment 240822 [details] Patch
Bear Travis
Comment 3 2014-11-02 20:12:31 PST
Yes, if CSSValueAuto is lurking in the code, it is from an older version of the spec that used 'auto' instead of 'none'. Will look into this more tomorrow.
Chris Dumez
Comment 4 2014-11-03 09:03:50 PST
Created attachment 240853 [details] Patch
Chris Dumez
Comment 5 2014-11-03 09:05:38 PST
I am just adding a FIXME about the CSSValueAuto in this patch since the idea is to move the code to the new StyleBuilder, not change behavior. Hopefully, Bear can update the code afterwards.
Zoltan Horvath
Comment 6 2014-11-03 10:52:12 PST
Comment on attachment 240853 [details] Patch Thanks for moving the code to the new StyleBuilder! Looks good.
WebKit Commit Bot
Comment 7 2014-11-03 11:40:19 PST
Comment on attachment 240853 [details] Patch Clearing flags on attachment: 240853 Committed r175481: <http://trac.webkit.org/changeset/175481>
WebKit Commit Bot
Comment 8 2014-11-03 11:40:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.