| Summary: | Move -webkit-shape-outside to the new StyleBuilder | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, betravis, buildbot, commit-queue, kling, koivisto, rniwa, sam, zoltan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 137910 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2014-11-02 16:00:19 PST
Bear, Zoltan, when looking at the ApplyPropertyShape<> code in DeprecatedStyleBuilder.cpp, I noticed that it is handling only CSSValueAuto as CSSPrimitiveValue. This does not seem right. The spec (and our CSS Parser) only seem to allow CSSValueNone as CSSPrimitiveValue. Should we update ApplyPropertyShape<> to all setShapeOutside(style, nullptr) when the value is CSSValueNone? (instead of CSSValueAuto). Created attachment 240822 [details]
Patch
Yes, if CSSValueAuto is lurking in the code, it is from an older version of the spec that used 'auto' instead of 'none'. Will look into this more tomorrow. Created attachment 240853 [details]
Patch
I am just adding a FIXME about the CSSValueAuto in this patch since the idea is to move the code to the new StyleBuilder, not change behavior. Hopefully, Bear can update the code afterwards. Comment on attachment 240853 [details]
Patch
Thanks for moving the code to the new StyleBuilder! Looks good.
Comment on attachment 240853 [details] Patch Clearing flags on attachment: 240853 Committed r175481: <http://trac.webkit.org/changeset/175481> All reviewed patches have been landed. Closing bug. |