Bug 138283

Summary: Move the -webkit-transform property to the new StyleBuilder
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch cdumez: review+

Sam Weinig
Reported 2014-11-01 14:34:41 PDT
Convert webkit-transform to use the new style builder
Attachments
Patch (6.05 KB, patch)
2014-11-01 14:39 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (6.05 KB, patch)
2014-11-01 14:39 PDT, Sam Weinig 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2014-11-01 14:39:23 PDT
Created attachment 240794 [details] Patch
Sam Weinig
Comment 2 2014-11-01 14:39:55 PDT
Created attachment 240795 [details] Patch
Chris Dumez
Comment 3 2014-11-01 14:45:15 PDT
Comment on attachment 240795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240795&action=review r=me with one thing to double-check. > Source/WebCore/css/CSSPropertyNames.in:492 > +-webkit-transform [NewStyleBuilder, NameForMethods=Transform, Converter=Transform] Do we really need to use the NameForMethods option here? makeprop.pl already strips the WebKit prefix for us so Transform should already be used.
Sam Weinig
Comment 4 2014-11-01 15:18:46 PDT
(In reply to comment #3) > Comment on attachment 240795 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240795&action=review > > r=me with one thing to double-check. > > > Source/WebCore/css/CSSPropertyNames.in:492 > > +-webkit-transform [NewStyleBuilder, NameForMethods=Transform, Converter=Transform] > > Do we really need to use the NameForMethods option here? makeprop.pl already > strips the WebKit prefix for us so Transform should already be used. Fixed.
Sam Weinig
Comment 5 2014-11-01 15:18:55 PDT
Committed revision 175454.
Note You need to log in before you can comment on or make changes to this bug.