Bug 138133

Summary: [EFL] Unskip passing ENCRYPTED_MEDIA_V2 tests
Product: WebKit Reporter: Éva Balázsfalvi <evab.u-szeged>
Component: Tools / TestsAssignee: Éva Balázsfalvi <evab.u-szeged>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Éva Balázsfalvi
Reported 2014-10-28 07:53:05 PDT
We should unskip now passing ENCRYPTED_MEDIA_V2 tests on EFL.
Attachments
Patch (2.16 KB, patch)
2014-10-28 08:21 PDT, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
Patch (2.21 KB, patch)
2014-11-03 05:15 PST, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.23 KB, patch)
2014-11-03 07:02 PST, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Éva Balázsfalvi
Comment 1 2014-10-28 08:21:12 PDT
Created attachment 240540 [details] Patch
Éva Balázsfalvi
Comment 2 2014-10-28 09:36:46 PDT
> LayoutTests/platform/efl/TestExpectations:1125 > +webkit.org/b/95297 media/encrypted-media [ Pass ] > +webkit.org/b/95297 fast/events/constructors/media-key-event-constructor.html [ Pass ] Marking these lines "Pass" instead of deleting them, because of LayoutTests/platform/efl/TestExpectations:496 webkit.org/b/131044 media [ Skip ] Removing the lines above would cause the ENCRYPTED_MEDIA_V2 related tests to skip because of this line.
Éva Balázsfalvi
Comment 3 2014-11-03 05:15:36 PST
Created attachment 240841 [details] Patch
Csaba Osztrogonác
Comment 4 2014-11-03 06:03:23 PST
Comment on attachment 240841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240841&action=review LGTM, but please fix the style before landing. > LayoutTests/platform/efl/TestExpectations:1127 > +webkit.org/b/95297 media/encrypted-media [ Pass ] > + > +# Failing, need to fix. https://bugs.webkit.org/show_bug.cgi?id=138307 > +media/encrypted-media/encrypted-media-can-play-type.html [ Skip ] webkit.org/b/138307 media/encrypted-media/encrypted-media-can-play-type.html [ Skip ]
Éva Balázsfalvi
Comment 5 2014-11-03 07:02:34 PST
Created attachment 240849 [details] Patch for landing
WebKit Commit Bot
Comment 6 2014-11-03 07:47:04 PST
Comment on attachment 240849 [details] Patch for landing Clearing flags on attachment: 240849 Committed r175470: <http://trac.webkit.org/changeset/175470>
WebKit Commit Bot
Comment 7 2014-11-03 07:47:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.