Bug 138125

Summary: Move "Number" CSS properties to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, buildbot, commit-queue, kling, koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2014-10-27 21:55:57 PDT 
Move "Number" CSS properties from DeprecatedStyleBuilder to the new StyleBuilder:
-webkit-hyphenate-limit-after / -webkit-hyphenate-limit-before / -webkit-shape-image-threshold

They are now generated from CSSPropertyNames.in
Comment 1 Chris Dumez 2014-10-27 23:02:58 PDT 
Created attachment 240530 [details]
Patch
Comment 2 Antti Koivisto 2014-10-28 07:53:36 PDT 
Comment on attachment 240530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240530&action=review

> Source/WebCore/css/CSSPropertyNames.in:340
> +-webkit-hyphenate-limit-after [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitAfter, Converter=Number<short>]
> +-webkit-hyphenate-limit-before [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitBefore, Converter=Number<short>]
> +-webkit-hyphenate-limit-lines [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitLines, Custom=Value]

You should add some documentation on how these annotations work, what the name mappings are, where the custom implementations should go and so on. Top of this file might be a good place.
Comment 3 Chris Dumez 2014-10-28 09:21:53 PDT 
Created attachment 240547 [details]
Patch
Comment 4 Chris Dumez 2014-10-28 09:22:38 PDT 
(In reply to comment #2)
> Comment on attachment 240530 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240530&action=review
> 
> > Source/WebCore/css/CSSPropertyNames.in:340
> > +-webkit-hyphenate-limit-after [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitAfter, Converter=Number<short>]
> > +-webkit-hyphenate-limit-before [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitBefore, Converter=Number<short>]
> > +-webkit-hyphenate-limit-lines [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitLines, Custom=Value]
> 
> You should add some documentation on how these annotations work, what the
> name mappings are, where the custom implementations should go and so on. Top
> of this file might be a good place.

Yes, I have just added the doc to this patch.
Comment 5 Chris Dumez 2014-10-28 10:29:22 PDT 
Created attachment 240552 [details]
Patch
Comment 6 WebKit Commit Bot 2014-10-28 12:12:35 PDT 
Comment on attachment 240552 [details]
Patch

Clearing flags on attachment: 240552

Committed r175267: <http://trac.webkit.org/changeset/175267>
Comment 7 WebKit Commit Bot 2014-10-28 12:12:40 PDT 
All reviewed patches have been landed.  Closing bug.