Bug 138125

Summary:

Move "Number" CSS properties to the new StyleBuilder

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

CSS

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, benjamin, buildbot, commit-queue, kling, koivisto, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

137910

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2014-10-27 21:55:57 PDT

Move "Number" CSS properties from DeprecatedStyleBuilder to the new StyleBuilder: -webkit-hyphenate-limit-after / -webkit-hyphenate-limit-before / -webkit-shape-image-threshold They are now generated from CSSPropertyNames.in

Attachments
Patch (19.36 KB, patch) 2014-10-27 23:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (21.39 KB, patch) 2014-10-28 09:21 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (20.92 KB, patch) 2014-10-28 10:29 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2014-10-27 23:02:58 PDT

Created attachment 240530 [details] Patch

Antti Koivisto

Comment 2 2014-10-28 07:53:36 PDT

Comment on attachment 240530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240530&action=review > Source/WebCore/css/CSSPropertyNames.in:340 > +-webkit-hyphenate-limit-after [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitAfter, Converter=Number<short>] > +-webkit-hyphenate-limit-before [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitBefore, Converter=Number<short>] > +-webkit-hyphenate-limit-lines [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitLines, Custom=Value] You should add some documentation on how these annotations work, what the name mappings are, where the custom implementations should go and so on. Top of this file might be a good place.

Chris Dumez

Comment 3 2014-10-28 09:21:53 PDT

Created attachment 240547 [details] Patch

Chris Dumez

Comment 4 2014-10-28 09:22:38 PDT

(In reply to comment #2) > Comment on attachment 240530 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240530&action=review > > > Source/WebCore/css/CSSPropertyNames.in:340 > > +-webkit-hyphenate-limit-after [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitAfter, Converter=Number<short>] > > +-webkit-hyphenate-limit-before [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitBefore, Converter=Number<short>] > > +-webkit-hyphenate-limit-lines [Inherited, NewStyleBuilder, NameForMethods=HyphenationLimitLines, Custom=Value] > > You should add some documentation on how these annotations work, what the > name mappings are, where the custom implementations should go and so on. Top > of this file might be a good place. Yes, I have just added the doc to this patch.

Chris Dumez

Comment 5 2014-10-28 10:29:22 PDT

Created attachment 240552 [details] Patch

WebKit Commit Bot

Comment 6 2014-10-28 12:12:35 PDT

Comment on attachment 240552 [details] Patch Clearing flags on attachment: 240552 Committed r175267: <http://trac.webkit.org/changeset/175267>

WebKit Commit Bot

Comment 7 2014-10-28 12:12:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.