Summary: | Move radius CSS properties to the new StyleBuilder | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | CSS | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, commit-queue, kling, koivisto, slewis | ||||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
URL: | http://src.chromium.org/viewvc/blink?view=revision&revision=155764 | ||||||||||
Bug Depends on: | 137910 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Chris Dumez
2014-10-26 16:06:25 PDT
Created attachment 240470 [details]
Patch
Comment on attachment 240470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240470&action=review > Source/WebCore/css/StyleBuilderConverter.h:175 > + ASSERT(pair && pair->first() && pair->second()); I would break this into (three) separate assertions so you can see which one is failing. > Source/WebCore/css/StyleBuilderConverter.h:181 > + ASSERT(!radiusWidth.isNegative() && !radiusHeight.isNegative()); Ditto here. Created attachment 240482 [details]
Patch
Comment on attachment 240482 [details] Patch Clearing flags on attachment: 240482 Committed r175222: <http://trac.webkit.org/changeset/175222> All reviewed patches have been landed. Closing bug. Seems to have caused a few crashes on the bots: https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r175222%20(9516)/results.html Looking into it now. Reopening due to crashes. Created attachment 240494 [details]
Patch
Committed r175228: <http://trac.webkit.org/changeset/175228> |