Bug 138087

Summary:

Move radius CSS properties to the new StyleBuilder

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

CSS

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, kling, koivisto, slewis

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://src.chromium.org/viewvc/blink?view=revision&revision=155764

Bug Depends on:

137910

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	kling: review+

Chris Dumez

Reported 2014-10-26 16:06:25 PDT

Move radius CSS properties from DeprecatedStyleBuilder to the new StyleBuilder so that they are now generated from CSSPropertyNames.in.

Attachments
Patch (11.20 KB, patch) 2014-10-26 17:53 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (11.23 KB, patch) 2014-10-27 08:49 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (1.79 KB, patch) 2014-10-27 12:50 PDT, Chris Dumez	kling: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2014-10-26 17:53:38 PDT

Created attachment 240470 [details] Patch

Andreas Kling

Comment 2 2014-10-26 19:19:04 PDT

Comment on attachment 240470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240470&action=review > Source/WebCore/css/StyleBuilderConverter.h:175 > + ASSERT(pair && pair->first() && pair->second()); I would break this into (three) separate assertions so you can see which one is failing. > Source/WebCore/css/StyleBuilderConverter.h:181 > + ASSERT(!radiusWidth.isNegative() && !radiusHeight.isNegative()); Ditto here.

Chris Dumez

Comment 3 2014-10-27 08:49:24 PDT

Created attachment 240482 [details] Patch

WebKit Commit Bot

Comment 4 2014-10-27 11:26:05 PDT

Comment on attachment 240482 [details] Patch Clearing flags on attachment: 240482 Committed r175222: <http://trac.webkit.org/changeset/175222>

WebKit Commit Bot

Comment 5 2014-10-27 11:26:10 PDT

All reviewed patches have been landed. Closing bug.

Chris Dumez

Comment 6 2014-10-27 12:29:27 PDT

Seems to have caused a few crashes on the bots: https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r175222%20(9516)/results.html Looking into it now.