Bug 138087

Summary: Move radius CSS properties to the new StyleBuilder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, koivisto, slewis
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://src.chromium.org/viewvc/blink?view=revision&revision=155764
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch kling: review+

Description Chris Dumez 2014-10-26 16:06:25 PDT
Move radius CSS properties from DeprecatedStyleBuilder to the new StyleBuilder so that they are now generated from CSSPropertyNames.in.
Comment 1 Chris Dumez 2014-10-26 17:53:38 PDT
Created attachment 240470 [details]
Patch
Comment 2 Andreas Kling 2014-10-26 19:19:04 PDT
Comment on attachment 240470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240470&action=review

> Source/WebCore/css/StyleBuilderConverter.h:175
> +    ASSERT(pair && pair->first() && pair->second());

I would break this into (three) separate assertions so you can see which one is failing.

> Source/WebCore/css/StyleBuilderConverter.h:181
> +    ASSERT(!radiusWidth.isNegative() && !radiusHeight.isNegative());

Ditto here.
Comment 3 Chris Dumez 2014-10-27 08:49:24 PDT
Created attachment 240482 [details]
Patch
Comment 4 WebKit Commit Bot 2014-10-27 11:26:05 PDT
Comment on attachment 240482 [details]
Patch

Clearing flags on attachment: 240482

Committed r175222: <http://trac.webkit.org/changeset/175222>
Comment 5 WebKit Commit Bot 2014-10-27 11:26:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Dumez 2014-10-27 12:29:27 PDT
Seems to have caused a few crashes on the bots:
https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r175222%20(9516)/results.html

Looking into it now.
Comment 7 Chris Dumez 2014-10-27 12:37:01 PDT
Reopening due to crashes.
Comment 8 Chris Dumez 2014-10-27 12:50:09 PDT
Created attachment 240494 [details]
Patch
Comment 9 Chris Dumez 2014-10-27 13:05:58 PDT
Committed r175228: <http://trac.webkit.org/changeset/175228>