Bug 138000

Summary: Move Length-type CSS properties from DeprecatedStyleBuilder to the new Style Builder
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, darin, kling, koivisto
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: https://src.chromium.org/viewvc/blink?view=rev&revision=150500
Bug Depends on: 137910    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2014-10-22 21:21:40 PDT
Move Length-type CSS properties from DeprecatedStyleBuilder to the new Style Builder so that they are now generated.
Attachments
WIP Patch (36.52 KB, patch)
2014-10-22 22:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (40.37 KB, patch)
2014-10-22 22:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (36.36 KB, patch)
2014-10-23 08:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-22 22:14:54 PDT
Created attachment 240328 [details] WIP Patch
Chris Dumez
Comment 2 2014-10-22 22:32:57 PDT
Created attachment 240329 [details] Patch
Andreas Kling
Comment 3 2014-10-22 23:38:39 PDT
Comment on attachment 240329 [details] Patch r=me, but I think we should keep the converter functions in the header file so they can be inlined as-needed in the generated code.
Chris Dumez
Comment 4 2014-10-23 08:31:04 PDT
Created attachment 240346 [details] Patch
Chris Dumez
Comment 5 2014-10-23 08:32:10 PDT
(In reply to comment #3) > Comment on attachment 240329 [details] > Patch > > r=me, but I think we should keep the converter functions in the header file > so they can be inlined as-needed in the generated code. Ok, I moved them out-of-class in the header and marked them as inline.
WebKit Commit Bot
Comment 6 2014-10-23 09:14:23 PDT
Comment on attachment 240346 [details] Patch Clearing flags on attachment: 240346 Committed r175123: <http://trac.webkit.org/changeset/175123>
WebKit Commit Bot
Comment 7 2014-10-23 09:14:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.