Summary: | [GTK] Prefer GTK implementation over native Windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Milan Crha <mcrha> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, benjamin, cfleizach, cgarcia, cmarcelo, commit-queue, dino, dmazzoni, gustavo, jcraig, jdiggs, kondapallykalyan, mario, mcatanzaro, mmaxfield, mrobinson, roger_fong, samuel_white | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 137488 | ||||||
Attachments: |
|
Description
Milan Crha
2014-10-22 11:36:07 PDT
Created attachment 240284 [details]
proposed wk patch
Comment on attachment 240284 [details] proposed wk patch View in context: https://bugs.webkit.org/attachment.cgi?id=240284&action=review Milan, sorry for the late review. I'm going to r- this simply because the GTK port does not have any support for Windows anymore. If that situation ever changes (if you or someone else ever gets it working), then of course it would make sense to reconsider this patch. > Source/WTF/wtf/Compiler.h:97 > +#define WTF_COMPILER_GCC 1 I don't think this is right; a quick Google search tells me that MinGW supports Clang. Even though clang pretends to be GCC, we don't want COMPILER(GCC) to return true unless the compiler really is GCC. |