Bug 137962
| Summary: | [Win] DumpRenderTree is improperly turning setShouldPaintNativeControls off | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bfulgham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | All | ||
Brent Fulgham
After turning off our use of the deprecated SafariTheme painting routines, it is now revealed that the standard rendering path for <select> on Windows is broken. This has been masked for a long time by the custom drawing routines in SafariTheme that are only used during layout tests.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
The following failures are due to this rendering bug:
editing/pasteboard/4641033.html
editing/pasteboard/4944770-1.html
editing/pasteboard/4944770-2.html
editing/selection/caret-before-select.html
editing/selection/select-box.html
editing/selection/select-element-paragraph-boundary.html
fast/block/float/float-avoidance.html
fast/block/margin-collapse/103.html
fast/forms/001.html
fast/forms/003.html
fast/forms/004.html
fast/forms/HTMLOptionElement_label01.html
fast/forms/HTMLOptionElement_label02.html
fast/forms/HTMLOptionElement_label03.html
fast/forms/HTMLOptionElement_label04.html
fast/forms/basic-selects.html
fast/forms/control-clip-overflow.html
fast/forms/control-restrict-line-height.html
fast/forms/menulist-deselect-update.html
fast/forms/menulist-narrow-width.html
fast/forms/menulist-no-overflow.html
fast/forms/select-align.html
fast/forms/select-baseline.html
fast/forms/select-change-listbox-to-popup.html
fast/forms/select-dirty-parent-pref-widths.html
fast/forms/select-selected.html
fast/forms/select-style.html
fast/forms/select/optgroup-rendering.html
fast/invalid/014.html
fast/parser/document-write-option.html
fast/replaced/replaced-breaking-mixture.html
fast/text/international/pop-up-button-text-alignment-and-direction.html
tables/mozilla/bugs/bug18359.html
tables/mozilla/bugs/bug29326.html
tables/mozilla/bugs/bug33855.html
tables/mozilla/bugs/bug4382.html
tables/mozilla/bugs/bug96334.html
tables/mozilla/core/margins.html
tables/mozilla/dom/tableDom.html
Brent Fulgham
Bad tests marked as failing in <http://trac.webkit.org/changeset/175054>.
Radar WebKit Bug Importer
<rdar://problem/18807814>
Radar WebKit Bug Importer
<rdar://problem/18807815>
Brent Fulgham
As of January, 2015 these have started working again. These problems may have been fixed by some of the rendering updates done in the past few weeks.
Brent Fulgham
(In reply to comment #5)
> As of January, 2015 these have started working again. These problems may
> have been fixed by some of the rendering updates done in the past few weeks.
Well that was totally wrong! It turns out that this is a rendering difference between WinLauncher and DumpRenderTree. The issue is that DRT is improperly calling setShouldPaintNativeControls(FALSE) during the run, which is wreaking havoc on the test runs.
Brent Fulgham
*** This bug has been marked as a duplicate of bug 25592 ***