| Summary: | Move std::unique_ptr<>|make_unique<> to WebCore/page/scrolling | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
| Component: | WebCore Misc. | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, jamesr, luiz, tonikitoo | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 128007 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Gyuyoung Kim
2014-10-20 04:27:11 PDT
Created attachment 240110 [details]
Patch
Created attachment 240119 [details]
Patch
Comment on attachment 240119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240119&action=review > Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:118 > - OwnPtr<ScrollingStateTree> treeState = scrollingStateTree()->commit(LayerRepresentation::PlatformLayerRepresentation); > + std::unique_ptr<ScrollingStateTree> treeState = scrollingStateTree()->commit(LayerRepresentation::PlatformLayerRepresentation); This doesn’t compile yet: /Volumes/Data/EWS/WebKit/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:119:31: error: no viable conversion from '__bind<void (WebCore::ThreadedScrollingTree::*)(std::__1::unique_ptr<WebCore::ScrollingStateTree, std::__1::default_delete<WebCore::ScrollingStateTree> >), WebCore::ThreadedScrollingTree *, WebCore::ScrollingStateTree *>' to 'std::function<void ()>' I don’t know exactly what’s wrong. *** Bug 138203 has been marked as a duplicate of this bug. *** Created attachment 247082 [details]
Patch
Comment on attachment 247082 [details] Patch Clearing flags on attachment: 247082 Committed r180493: <http://trac.webkit.org/changeset/180493> All reviewed patches have been landed. Closing bug. |