Bug 137840

Summary: Use is<>() / downcast<>() for all SVG RenderObjects
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: SVGAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dino, dmazzoni, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jcraig, jdiggs, kondapallykalyan, mario, mmaxfield, pdr, samuel_white, schenney, sergio, simon.fraser, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137424    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2014-10-17 16:14:35 PDT
Use is<>() / downcast<>() for all SVG RenderObjects
Attachments
Patch (32.98 KB, patch)
2014-10-17 16:18 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-17 16:18:04 PDT
Created attachment 240050 [details] Patch
Benjamin Poulain
Comment 2 2014-10-17 16:41:13 PDT
Comment on attachment 240050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240050&action=review > Source/WebCore/rendering/RenderLayerFilterInfo.cpp:131 > + for (const auto& filter : m_internalSVGReferences) { Shouldn't this be const auto*? > Source/WebCore/rendering/svg/SVGRootInlineBox.cpp:-80 > - RenderSVGText* textRoot = toRenderSVGText(&blockFlow()); > - ASSERT(textRoot); ahahahahah
Chris Dumez
Comment 3 2014-10-17 16:43:44 PDT
Comment on attachment 240050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240050&action=review >> Source/WebCore/rendering/RenderLayerFilterInfo.cpp:131 >> + for (const auto& filter : m_internalSVGReferences) { > > Shouldn't this be const auto*? It is a RefPtr type.
WebKit Commit Bot
Comment 4 2014-10-17 17:21:45 PDT
Comment on attachment 240050 [details] Patch Clearing flags on attachment: 240050 Committed r174854: <http://trac.webkit.org/changeset/174854>
WebKit Commit Bot
Comment 5 2014-10-17 17:21:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.